Changeset 9753 for trunk/src/bp-messages/classes/class-bp_messages-thread.php

Timestamp:

04/15/2015 10:44:55 PM (11 years ago)

Author:

r-a-y

Message:

Messages: Cache calls to BP_Messages_Thread class.

This commit:

• Introduces static method - BP_Messages_Thread::get_messages() - caches fetching messages by thread ID and introduces the 'bp_messages_threads' cache group.
• Converts BP_Messages_Thread::check_access() and BP_Messages_Thread::is_valid() methods from using direct DB queries to reference the cache.
• Includes unit tests.
• Consolidates cache clearing functions in bp-messages-cache.php.

This handles the majority of uncached message DB queries. For the inbox
page, if there are 10 message threads in the loop, we save 20 DB queries.
On a single message thread, we save 5 DB queries.

Fixes #6221.

File:

• trunk/src/bp-messages/classes/class-bp_messages-thread.php (modified) (5 diffs)

trunk/src/bp-messages/classes/class-bp_messages-thread.php

@@ -148 +148 @@
                 $this->thread_id      = $thread_id;
 
-                $bp = buddypress();
-
-                if ( !$this->messages = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM {$bp->messages->table_name_messages} WHERE thread_id = %d ORDER BY date_sent " . $order, $this->thread_id ) ) ) {
+                // get messages for thread
+                $this->messages = self::get_messages( $thread_id );
+
+                if ( empty( $this->messages ) || is_wp_error( $this->messages ) ) {
                         return false;
+                }
+
+                // flip if order is DESC
+                if ( 'DESC' === $order ) {
+                        $this->messages = array_reverse( $this->messages );
                 }
 
@@ -245 +251 @@
 
         /** Static Functions ******************************************************/
+
+        /**
+         * Get all messages associated with a thread.
+         *
+         * @since BuddyPress (2.3.0)
+         *
+         * @param int $thread_id The message thread ID
+         * @return array
+         */
+        public static function get_messages( $thread_id = 0 ) {
+                $messages = wp_cache_get( $thread_id, 'bp_messages_threads' );
+
+                if ( false === $messages ) {
+                        global $wpdb;
+
+                        $bp = buddypress();
+
+                        // always sort by ASC by default
+                        $messages = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM {$bp->messages->table_name_messages} WHERE thread_id = %d ORDER BY date_sent ASC", $thread_id ) );
+
+                        wp_cache_set( $thread_id, (array) $messages, 'bp_messages_threads' );
+                }
+
+                return $messages;
+        }
 
         /**
@@ -664 +695 @@
          * @param int $thread_id The message thread ID.
          * @param int $user_id The user ID.
-         * @return int The message ID on success.
+         * @return int|null The recorded recipient ID on success, null on failure
          */
         public static function check_access( $thread_id, $user_id = 0 ) {
-                global $wpdb;
-
-                if ( empty( $user_id ) )
+                if ( empty( $user_id ) ) {
                         $user_id = bp_loggedin_user_id();
-
-                $bp = buddypress();
-
-                return $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$bp->messages->table_name_recipients} WHERE thread_id = %d AND is_deleted = 0 AND user_id = %d", $thread_id, $user_id ) );
+                }
+
+                $recipients = self::get_recipients_for_thread( $thread_id );
+
+                if ( isset( $recipients[$user_id] ) && 0 == $recipients[$user_id]->is_deleted ) {
+                        return $recipients[$user_id]->id;
+                } else {
+                        return null;
+                }
         }
 
@@ -683 +717 @@
          *
          * @param int $thread_id The message thread ID.
-         * @return int The message thread ID on success.
+         * @return int|null The message thread ID on success, null on failure
          */
         public static function is_valid( $thread_id = 0 ) {
-                global $wpdb;
-
                 // Bail if no thread ID is passed
                 if ( empty( $thread_id ) ) {
@@ -693 +725 @@
                 }
 
-                $bp = buddypress();
-
-                return $wpdb->get_var( $wpdb->prepare( "SELECT thread_id FROM {$bp->messages->table_name_messages} WHERE thread_id = %d LIMIT 1", $thread_id ) );
+                $thread = self::get_messages( $thread_id );
+
+                if ( ! empty( $thread ) ) {
+                        return $thread_id;
+                } else {
+                        return null;
+                }
         }