Changeset 9716

Timestamp:

04/07/2015 01:28:21 PM (10 years ago)

Author:

boonebgorges

Message:

Introduce bp_pre_schema_upgrade() and use it to drop old meta_key indexes.

After [9695], BP tries to update existing indexes using dbDelta(), but
dbDelta() cannot DROP INDEX properly. So we must run a separate routine
before the regular schema updates. See WP's pre_schema_upgrade().

See #6346.

Location:

trunk/src

Files:

• bp-core/admin/bp-core-admin-schema.php (modified) (1 diff)
• bp-core/bp-core-update.php (modified) (1 diff)
• bp-loader.php (modified) (1 diff)

trunk/src/bp-core/admin/bp-core-admin-schema.php

@@ -38 +38 @@
  */
 function bp_core_install( $active_components = false ) {
+
+    bp_pre_schema_upgrade();
 
     // If no components passed, get all the active components from the main site

trunk/src/bp-core/bp-core-update.php

@@ -258 +258 @@
     // Bump the version
     bp_version_bump();
+}
+
+/**
+ * Perform database operations that must take place before the general schema upgrades.
+ *
+ * `dbDelta()` cannot handle certain operations - like changing indexes - so we do it here instead.
+ *
+ * @since BuddyPress (2.3.0)
+ */
+function bp_pre_schema_upgrade() {
+    global $wpdb;
+
+    $raw_db_version = (int) bp_get_db_version_raw();
+    $bp_prefix      = bp_core_get_table_prefix();
+
+    // 2.3.0: Change index lengths to account for utf8mb4.
+    if ( $raw_db_version < 9695 ) {
+        // table_name => columns.
+        $tables = array(
+            $bp_prefix . 'bp_activity_meta'       => array( 'meta_key' ),
+            $bp_prefix . 'bp_groups_groupmeta'    => array( 'meta_key' ),
+            $bp_prefix . 'bp_messages_meta'       => array( 'meta_key' ),
+            $bp_prefix . 'bp_notifications_meta'  => array( 'meta_key' ),
+            $bp_prefix . 'bp_user_blogs_blogmeta' => array( 'meta_key' ),
+            $bp_prefix . 'bp_xprofile_meta'       => array( 'meta_key' ),
+        );
+
+        foreach ( $tables as $table_name => $indexes ) {
+            foreach ( $indexes as $index ) {
+                $wpdb->query( "ALTER TABLE $table_name DROP INDEX $index" );
+            }
+        }
+    }
 }
 

trunk/src/bp-loader.php

@@ -306 +306 @@
 
         $this->version    = '2.3-alpha';
-        $this->db_version = 9615;
+        $this->db_version = 9695;
 
         /** Loading ***********************************************************/