Changeset 9711 for trunk/tests/phpunit/testcases/xprofile/functions.php

Timestamp:

04/07/2015 12:54:07 AM (10 years ago)

Author:

boonebgorges

Message:

Improve parameter sanitization in xprofile_insert_field().

The overzealous empty() checks meant that it was impossible to set certain
values on existing fields to falsey values.

Fixes #6354.

File:

• trunk/tests/phpunit/testcases/xprofile/functions.php (modified) (1 diff)

trunk/tests/phpunit/testcases/xprofile/functions.php

@@ -646 +646 @@
     /**
      * @group xprofile_insert_field
+     * @ticket BP6354
+     */
+    public function test_xprofile_insert_field_should_process_falsey_values_for_boolean_params_on_existing_fields() {
+        $g = $this->factory->xprofile_group->create();
+        $f = xprofile_insert_field( array(
+            'field_group_id' => $g,
+            'type' => 'textbox',
+            'name' => 'Foo',
+            'is_required' => true,
+            'can_delete' => true,
+            'is_default_option' => true,
+            'parent_id' => 13,
+            'field_order' => 5,
+            'option_order' => 8,
+            'description' => 'foo',
+            'order_by' => 'custom',
+        ) );
+
+        $this->assertNotEmpty( $f );
+
+        $field = new BP_XProfile_Field( $f );
+        $this->assertEquals( 1, $field->is_required );
+        $this->assertEquals( 1, $field->can_delete );
+        $this->assertEquals( 1, $field->is_default_option );
+        $this->assertEquals( 13, $field->parent_id );
+        $this->assertEquals( 5, $field->field_order );
+        $this->assertEquals( 8, $field->option_order );
+        $this->assertEquals( 'foo', $field->description );
+        $this->assertEquals( 'custom', $field->order_by );
+
+        $f = xprofile_insert_field( array(
+            'field_group_id' => $g,
+            'type' => 'textbox',
+            'name' => 'Foo',
+            'is_required' => false,
+            'can_delete' => false,
+            'is_default_option' => false,
+            'parent_id' => 0,
+            'field_order' => 0,
+            'option_order' => 0,
+            'description' => '',
+            'order_by' => '',
+        ) );
+
+        $this->assertNotEmpty( $f );
+
+        $field = new BP_XProfile_Field( $f );
+        $this->assertEquals( 0, $field->is_required );
+        $this->assertEquals( 0, $field->can_delete );
+        $this->assertEquals( 0, $field->is_default_option );
+        $this->assertEquals( 0, $field->parent_id );
+        $this->assertEquals( 0, $field->field_order );
+        $this->assertEquals( 0, $field->option_order );
+        $this->assertEquals( '', $field->description );
+        $this->assertEquals( '', $field->order_by );
+    }
+
+    /**
+     * @group xprofile_insert_field
      */
     public function test_xprofile_insert_field_type_option_option_order() {