Changeset 9707

Timestamp:

04/06/2015 09:14:50 PM (10 years ago)

Author:

boonebgorges

Message:

Don't let bp_create_excerpt() truncate to empty strings.

When the first word of a string is longer than the $length param, the word
should be truncated mid-word, even if exact=false.

Fixes #6254.

Location:

trunk

Files:

• src/bp-core/bp-core-template.php (modified) (1 diff)
• tests/phpunit/testcases/core/template/bpCreateExcerpt.php (modified) (1 diff)

trunk/src/bp-core/bp-core-template.php

@@ -745 +745 @@
     if ( empty( $r['exact'] ) ) {
         $spacepos = mb_strrpos( $truncate, ' ' );
-        if ( isset( $spacepos ) ) {
+        if ( false !== $spacepos ) {
             if ( $r['html'] ) {
                 $bits = mb_substr( $truncate, $spacepos );

trunk/tests/phpunit/testcases/core/template/bpCreateExcerpt.php

@@ -41 +41 @@
         ) ) );
     }
+
+    public function test_should_break_on_prior_word_boundary_when_exact_is_false() {
+        $text = 'aaaaa aaaaaa';
+        $expected = 'aaaaa';
+        $this->assertSame( $expected, bp_create_excerpt( $text, 7, array(
+            'exact' => false,
+            'ending' => '',
+        ) ) );
+    }
+
+    /**
+     * @ticket BP6254
+     */
+    public function test_should_trim_too_long_first_word_to_max_characters_even_when_exact_is_false() {
+        $text = 'aaaaaaaaaaa';
+        $expected = 'aaa';
+        $this->assertSame( $expected, bp_create_excerpt( $text, 3, array(
+            'exact' => false,
+            'ending' => '',
+        ) ) );
+    }
 }