Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
02/27/2015 03:00:42 AM (9 years ago)
Author:
boonebgorges
Message:

Don't create a current user by default in most unit tests.

The default state of our tests should be as a logged-out user. BP does pretty
different things with different kinds of logged-in users, so individual tests
should decide for themselves what the current user status should be.

Moreover, the creation of fixture users is fairly resource-intensive. Not
creating users when they're not needed makes the test suite run 5-10% faster.

See #6009.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/members/template.php

    r9417 r9561  
    44 */
    55class BP_Tests_Members_Template extends BP_UnitTestCase {
    6     protected $old_current_user = 0;
    7 
    8     public function setUp() {
    9         parent::setUp();
    10 
    11         $this->old_current_user = get_current_user_id();
    12         $new_user = $this->factory->user->create( array( 'role' => 'administrator' ) );
    13         $this->set_current_user( $new_user );
    14 
    15     }
    16 
    17     public function tearDown() {
    18         parent::tearDown();
    19         $this->set_current_user( $this->old_current_user );
    20     }
    21 
    226    public function test_bp_has_members_include_on_user_page() {
    237        $u1 = $this->factory->user->create();
Note: See TracChangeset for help on using the changeset viewer.