Changeset 9561 for trunk/tests/phpunit/testcases/core/avatars.php

Timestamp:

02/27/2015 03:00:42 AM (10 years ago)

Author:

boonebgorges

Message:

Don't create a current user by default in most unit tests.

The default state of our tests should be as a logged-out user. BP does pretty
different things with different kinds of logged-in users, so individual tests
should decide for themselves what the current user status should be.

Moreover, the creation of fixture users is fairly resource-intensive. Not
creating users when they're not needed makes the test suite run 5-10% faster.

See #6009.

File:

• trunk/tests/phpunit/testcases/core/avatars.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/core/avatars.php

@@ -5 +5 @@
  */
 class BP_Tests_Avatars extends BP_UnitTestCase {
-    protected $old_current_user = 0;
-
     private $params = array();
-
-    public function setUp() {
-        parent::setUp();
-
-        $this->old_current_user = get_current_user_id();
-        $this->administrator    = $this->factory->user->create( array( 'role' => 'administrator' ) );
-        wp_set_current_user( $this->administrator );
-    }
-
-    public function tearDown() {
-        parent::tearDown();
-        wp_set_current_user( $this->old_current_user );
-    }
 
     private function clean_existing_avatars( $type = 'user' ) {
@@ -59 +44 @@
         }
 
+        $u = $this->factory->user->create();
+
         // get BP root blog's upload directory data
         $upload_dir = wp_upload_dir();
@@ -64 +51 @@
         // create new subsite
         $blog_id = $this->factory->blog->create( array(
-            'user_id' => $this->administrator,
+            'user_id' => $u,
             'title'   => 'Test Title',
             'path'    => '/path' . rand() . time() . '/',