Changeset 9533 for trunk/tests/phpunit/testcases/members/types.php

Timestamp:

02/23/2015 01:39:05 AM (11 years ago)

Author:

boonebgorges

Message:

Use 'bp_member_member_type' as the member type cache bucket name.

Using 'bp_member_type' was creating the potential for collisions between WP's
taxonomy cache (which uses the taxonomy name 'bp_member_type' and term IDs as
cache keys) and BP's per-member member type cache (which uses the bucket
'bp_member_type' and user IDs as cache keys). The collisions take place only
when there is a 'bp_member_type' term ID that overlaps with a user ID.

The new cache group 'bp_member_member_type' is chosen to underscore that what's
being cached is the relationship between individual members and the user types
to which they belong.

Props imath, johnjamesjacoby.
Fixes #6242.

File:

• trunk/tests/phpunit/testcases/members/types.php (modified) (1 diff)

trunk/tests/phpunit/testcases/members/types.php

@@ -206 +206 @@
         $this->assertFalse( bp_get_member_type( $u ) );
     }
+
+    /**
+     * @group BP6242
+     * @group cache
+     */
+    public function test_bp_get_member_type_should_not_conflict_with_term_cache() {
+        global $wpdb;
+
+        // Offset IDs.
+        $dummy_terms = $this->factory->tag->create_many( 5 );
+
+        $u1 = $this->factory->user->create();
+        bp_register_member_type( 'foo' );
+        bp_set_member_type( $u1, 'foo' );
+
+        // Fetch a term ID.
+        $terms = get_terms( 'bp_member_type', array( 'hide_empty' => false, 'fields' => 'all' ) );
+
+        // Make sure the user's ID matches a term ID, to force a cache confusion.
+        $u2 = $this->factory->user->create();
+        $new_user_id = $terms[0]->term_id;
+        $wpdb->update( $wpdb->users, array( 'ID' => $new_user_id ), array( 'ID' => $u2 ) );
+
+        bp_set_member_type( $new_user_id, 'foo' );
+
+        // Reprime the taxonomy cache.
+        $terms = get_terms( 'bp_member_type', array( 'hide_empty' => false, 'fields' => 'all' ) );
+
+        $this->assertSame( 'foo', bp_get_member_type( $new_user_id, true ) );
+    }
 }