Changeset 9533 for trunk/src/bp-members/bp-members-functions.php

Timestamp:

02/23/2015 01:39:05 AM (10 years ago)

Author:

boonebgorges

Message:

Use 'bp_member_member_type' as the member type cache bucket name.

Using 'bp_member_type' was creating the potential for collisions between WP's
taxonomy cache (which uses the taxonomy name 'bp_member_type' and term IDs as
cache keys) and BP's per-member member type cache (which uses the bucket
'bp_member_type' and user IDs as cache keys). The collisions take place only
when there is a 'bp_member_type' term ID that overlaps with a user ID.

The new cache group 'bp_member_member_type' is chosen to underscore that what's
being cached is the relationship between individual members and the user types
to which they belong.

Props imath, johnjamesjacoby.
Fixes #6242.

File:

• trunk/src/bp-members/bp-members-functions.php (modified) (2 diffs)

trunk/src/bp-members/bp-members-functions.php

@@ -2584 +2584 @@
     // Bust the cache if the type has been updated.
     if ( ! is_wp_error( $retval ) ) {
-        wp_cache_delete( $user_id, 'bp_member_type' );
+        wp_cache_delete( $user_id, 'bp_member_member_type' );
 
         /**
@@ -2613 +2613 @@
  */
 function bp_get_member_type( $user_id, $single = true ) {
-    $types = wp_cache_get( $user_id, 'bp_member_type' );
+    $types = wp_cache_get( $user_id, 'bp_member_member_type' );
 
     if ( false === $types ) {
-        $types = bp_get_object_terms( $user_id, 'bp_member_type'  );
+        $types = bp_get_object_terms( $user_id, 'bp_member_type' );
 
         if ( ! is_wp_error( $types ) ) {
             $types = wp_list_pluck( $types, 'name' );
-            wp_cache_set( $user_id, $types, 'bp_member_type' );
+            wp_cache_set( $user_id, $types, 'bp_member_member_type' );
         }
     }