Changeset 9447 for trunk/src/bp-members/bp-members-cache.php

Timestamp:

02/07/2015 08:32:55 PM (11 years ago)

Author:

boonebgorges

Message:

When prefetching member types in the loop, cache arrays instead of strings.

Member type caches should always be arrays of all member types for a user.

Props imath.
Fixes #6193.

File:

• trunk/src/bp-members/bp-members-cache.php (modified) (1 diff)

trunk/src/bp-members/bp-members-cache.php

@@ -21 +21 @@
     ) );
 
+    // Rekey by user ID.
+    $keyed_member_types = array();
+    foreach ( $member_types as $member_type ) {
+        if ( ! isset( $keyed_member_types[ $member_type->object_id ] ) ) {
+            $keyed_member_types[ $member_type->object_id ] = array();
+        }
+
+        $keyed_member_types[ $member_type->object_id ][] = $member_type->name;
+    }
+
     $cached_member_ids = array();
-    foreach ( $member_types as $member_type ) {
-        wp_cache_set( $member_type->object_id, $member_type->name, 'bp_member_type' );
-        $cached_member_ids[] = $member_type->object_id;
+    foreach ( $keyed_member_types as $user_id => $user_member_types ) {
+        wp_cache_set( $user_id, $user_member_types, 'bp_member_type' );
+        $cached_member_ids[] = $user_id;
     }