Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
01/29/2015 04:33:39 PM (10 years ago)
Author:
johnjamesjacoby
Message:

Use bp_sanitize_pagination_arg() in BP_Messages_Box_Template and include related tests. This prevents pagination values from being overridden outside of anticipated boundaries. See #5796.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/messages/template.php

    r9335 r9415  
    258258        $this->assertEqualSets( array( $t1 ), wp_list_pluck( $messages_template->threads, 'thread_id' ) );
    259259    }
     260
     261    /**
     262     * @group BP_Messages_Box_Template
     263     */
     264    public function test_bp_messages_template_should_give_precedence_to_mpage_URL_param() {
     265        $request = $_REQUEST;
     266        $_REQUEST['mpage'] = '5';
     267
     268        $at = new BP_Messages_Box_Template( array(
     269            'page' => 8,
     270        ) );
     271
     272        $this->assertEquals( 5, $at->pag_page );
     273
     274        $_REQUEST = $request;
     275    }
     276
     277    /**
     278     * @group BP_Messages_Box_Template
     279     */
     280    public function test_bp_messages_template_should_reset_0_pag_page_URL_param_to_default_pag_page_value() {
     281        $request = $_REQUEST;
     282        $_REQUEST['mpage'] = '0';
     283
     284        $at = new BP_Messages_Box_Template( array(
     285            'page' => 8,
     286        ) );
     287
     288        $this->assertEquals( 8, $at->pag_page );
     289
     290        $_REQUEST = $request;
     291    }
     292
     293    /**
     294     * @group BP_Messages_Box_Template
     295     */
     296    public function test_bp_messages_template_should_give_precedence_to_num_URL_param() {
     297        $request = $_REQUEST;
     298        $_REQUEST['num'] = '14';
     299
     300        $at = new BP_Messages_Box_Template( array(
     301            'per_page' => 13,
     302        ) );
     303
     304        $this->assertEquals( 14, $at->pag_num );
     305
     306        $_REQUEST = $request;
     307    }
     308
     309    /**
     310     * @group BP_Messages_Box_Template
     311     */
     312    public function test_bp_messages_template_should_reset_0_pag_num_URL_param_to_default_pag_num_value() {
     313        $request = $_REQUEST;
     314        $_REQUEST['num'] = '0';
     315
     316        $at = new BP_Messages_Box_Template( array(
     317            'per_page' => 13,
     318        ) );
     319
     320        $this->assertEquals( 13, $at->pag_num );
     321
     322        $_REQUEST = $request;
     323    }
    260324}
Note: See TracChangeset for help on using the changeset viewer.