Changeset 9399

Timestamp:

01/22/2015 05:47:27 PM (12 years ago)

Author:

johnjamesjacoby

Message:

Move page-template support into BP Legacy template pack. Props imath. See #6065.

Location:

trunk/src

Files:

• bp-core/bp-core-filters.php (modified) (1 diff)
• bp-core/bp-core-template-loader.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress-functions.php (modified) (4 diffs)

trunk/src/bp-core/bp-core-filters.php

@@ -65 +65 @@
 // Filter BuddyPress template locations
 add_filter( 'bp_get_template_stack', 'bp_add_template_stack_locations' );
-
-// Filter BuddyPress template hierarchy and look for page templates
-add_filter( 'bp_get_buddypress_template', 'bp_theme_compat_page_templates' );
 
 // Turn comments off for BuddyPress pages

trunk/src/bp-core/bp-core-template-loader.php

@@ -463 +463 @@
         ) );
 }
-
-/**
- * Filter the default theme compatibility root template hierarchy, and prepend
- * a page template to the front if it's set.
- *
- * @see https://buddypress.trac.wordpress.org/ticket/6065
- *
- * @since BuddyPress (2.2.0)
- *
- * @param  array $templates
- * @return array
- */
-function bp_theme_compat_page_templates( $templates = array() ) {
-
-        // Bail if not looking at a directory
-        if ( ! bp_is_directory() ) {
-                return $templates;
-        }
-
-        // No page ID yet
-        $page_id = 0;
-
-        // Get the WordPress Page ID for the current view.
-        foreach ( (array) buddypress()->pages as $component => $bp_page ) {
-
-                // Handles the majority of components.
-                if ( bp_is_current_component( $component ) ) {
-                        $page_id = (int) $bp_page->id;
-                }
-
-                // Stop if not on a user page.
-                if ( ! bp_is_user() && ! empty( $page_id ) ) {
-                        break;
-                }
-
-                // The Members component requires an explicit check due to overlapping components.
-                if ( bp_is_user() && ( 'members' === $component ) ) {
-                        $page_id = (int) $bp_page->id;
-                        break;
-                }
-        }
-
-        // Bail if no directory page set
-        if ( 0 === $page_id ) {
-                return $templates;
-        }
-
-        // Check for page template
-        $page_template = get_page_template_slug( $page_id );
-
-        // Add it to the beginning of the templates array so it takes precedence
-        // over the default hierarchy.
-        if ( ! empty( $page_template ) ) {
-                array_unshift( $templates, $page_template );
-        }
-
-        return $templates;
-}

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -81 +81 @@
                 add_filter( 'bp_get_activity_action_pre_meta', array( $this, 'secondary_avatars' ), 10, 2 );
 
+                // Filter BuddyPress template hierarchy and look for page templates
+                add_filter( 'bp_get_buddypress_template', array( $this, 'theme_compat_page_templates' ), 10, 1 );
+
                 /** Scripts ***********************************************************/
 
@@ -88 +91 @@
                 add_action( 'bp_head',            array( $this, 'head_scripts'     ) ); // Output some extra JS in the <head>
 
-                /** Body no-js Class ********************************************************/
+                /** Body no-js Class **************************************************/
+
                 add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
 
@@ -120 +124 @@
                                 add_action( 'bp_blogs_directory_blog_types', 'bp_legacy_theme_blog_create_nav', 999 );
                         }
-
-
                 }
 
@@ -441 +443 @@
                 return $action;
         }
+
+        /**
+         * Filter the default theme compatibility root template hierarchy, and prepend
+         * a page template to the front if it's set.
+         *
+         * @see https://buddypress.trac.wordpress.org/ticket/6065
+         *
+         * @since BuddyPress (2.2.0)
+         *
+         * @param  array $templates
+         * @uses   apply_filters() call 'bp_legacy_theme_compat_page_templates_directory_only' and return false
+         *                         to use the defined page template for component's directory and its single items
+         * @return array
+         */
+        public function theme_compat_page_templates( $templates = array() ) {
+
+                // Bail if not looking at a directory
+                if ( true === (bool) apply_filters( 'bp_legacy_theme_compat_page_templates_directory_only', ! bp_is_directory() ) ) {
+                        return $templates;
+                }
+
+                // No page ID yet
+                $page_id = 0;
+
+                // Get the WordPress Page ID for the current view.
+                foreach ( (array) buddypress()->pages as $component => $bp_page ) {
+
+                        // Handles the majority of components.
+                        if ( bp_is_current_component( $component ) ) {
+                                $page_id = (int) $bp_page->id;
+                        }
+
+                        // Stop if not on a user page.
+                        if ( ! bp_is_user() && ! empty( $page_id ) ) {
+                                break;
+                        }
+
+                        // The Members component requires an explicit check due to overlapping components.
+                        if ( bp_is_user() && ( 'members' === $component ) ) {
+                                $page_id = (int) $bp_page->id;
+                                break;
+                        }
+                }
+
+                // Bail if no directory page set
+                if ( 0 === $page_id ) {
+                        return $templates;
+                }
+
+                // Check for page template
+                $page_template = get_page_template_slug( $page_id );
+
+                // Add it to the beginning of the templates array so it takes precedence
+                // over the default hierarchy.
+                if ( ! empty( $page_template ) ) {
+                        array_unshift( $templates, $page_template );
+                }
+
+                return $templates;
+        }
 }
 new BP_Legacy();