Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
01/20/2015 06:50:52 PM (7 years ago)
Author:
boonebgorges
Message:

In bp_activity_generate_action_string(), use bp_activity_get_actions() rather than touching global directly.

This change ensures that the filters called by bp_activity_get_actions() are
run, which gives a chance for dynamically registered actions to register
themselves just in time whenever an activity string needs to be generated.

This change is a more general fix than the one introduced in [9366], so that
changeset (minus its unit tests) has been rolled back. See #6126.

Fixes #6141.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-activity/bp-activity-classes.php

    r9380 r9382  
    163163            $this->is_spam           = $row->is_spam;
    164164        }
    165 
    166         /**
    167          * Make sure the activity actions have been registered.
    168          * We can't assume it will already be set because this is normally only done on an ad-hoc basis.
    169          *
    170          * @link https://buddypress.trac.wordpress.org/ticket/6126
    171          */
    172         bp_activity_get_actions();
    173165
    174166        // Generate dynamic 'action' when possible
Note: See TracChangeset for help on using the changeset viewer.