Changeset 9371

Timestamp:

01/19/2015 01:53:22 PM (10 years ago)

Author:

boonebgorges

Message:

Sanitize member_type key in bp_register_member_type().

Props Offereins.
Fixes #6139.

Location:

trunk

Files:

• src/bp-members/bp-members-functions.php (modified) (1 diff)
• tests/phpunit/testcases/members/types.php (modified) (1 diff)

trunk/src/bp-members/bp-members-functions.php

@@ -2481 +2481 @@
     ), 'register_member_type' );
 
+    $member_type = sanitize_key( $member_type );
+
     // Store the post type name as data in the object (not just as the array key).
     $r['name'] = $member_type;

trunk/tests/phpunit/testcases/members/types.php

@@ -19 +19 @@
     public function test_bp_register_member_type_should_return_type_object() {
         $this->assertInternalType( 'object', bp_register_member_type( 'foo' ) );
+    }
+
+    /**
+     * @ticket BP6139
+     */
+    public function test_bp_register_member_type_should_sanitize_member_type_key() {
+        $key = 'F//oo% -Bar';
+        $sanitized_key = 'foo-bar';
+
+        $object = bp_register_member_type( $key );
+        $this->assertSame( $sanitized_key, $object->name );
     }