Changeset 9332

Timestamp:

01/09/2015 07:31:32 PM (10 years ago)

Author:

r-a-y

Message:

Messages: Use INNER JOIN in BP_Messages_Thread::get_current_threads_for_user()

This commit uses INNER JOIN for compiling the SQL statement to better
prepare for meta queries with messages.

Props Mamaduka.

See #6063.

File:

• trunk/src/bp-messages/bp-messages-classes.php (modified) (1 diff)

trunk/src/bp-messages/bp-messages-classes.php

@@ -394 +394 @@
         $sql = array();
         $sql['select'] = 'SELECT m.thread_id, MAX(m.date_sent) AS date_sent';
-        $sql['from']   = "FROM {$bp->messages->table_name_recipients} r, {$bp->messages->table_name_messages} m";
-        $sql['where']  = "WHERE m.thread_id = r.thread_id AND r.is_deleted = 0 {$user_id_sql} {$sender_sql} {$type_sql} {$search_sql}";
+        $sql['from']   = "FROM {$bp->messages->table_name_recipients} r INNER JOIN {$bp->messages->table_name_messages} m ON m.thread_id = r.thread_id";
+        $sql['where']  = "WHERE r.is_deleted = 0 {$user_id_sql} {$sender_sql} {$type_sql} {$search_sql}";
         $sql['misc']   = "GROUP BY m.thread_id ORDER BY date_sent DESC {$pag_sql}";