Changeset 9330 for trunk/src/bp-activity/bp-activity-classes.php

Timestamp:

01/09/2015 06:47:34 PM (10 years ago)

Author:

r-a-y

Message:

Activity: Scopes with no generated SQL statement should match nothing.

Commit also adds unit tests demonstrating the problem.

Props imath.

Fixes #6099.

File:

• trunk/src/bp-activity/bp-activity-classes.php (modified) (1 diff)

trunk/src/bp-activity/bp-activity-classes.php

@@ -349 +349 @@
             $scope_query = self::get_scope_query_sql( $r['scope'], $r );
 
+            // Add our SQL conditions if matches were found
             if ( ! empty( $scope_query['sql'] ) ) {
                 $where_conditions['scope_query_sql'] = $scope_query['sql'];
+
+            // No matches, so we should alter the SQL statement to match nothing
+            } else {
+                $where_conditions['scope_no_results'] = '0 = 1';
             }