Changeset 9328 for trunk/tests/phpunit/testcases/blogs/class-bp-blogs-blog.php

Timestamp:

01/09/2015 04:06:51 PM (10 years ago)

Author:

boonebgorges

Message:

Search consistently against blog title and description in BP_Blogs_Blog::get().

Previously, the description field was only being matched for the 'total' query,
with the result that pagination and other count-based results did not match the
blogs actually returned by the query.

This changeset reworks the syntax a bit, to avoid the duplicated logic when
using search terms, and to use proper JOIN syntax instead of commas.

Props jreeve.
Fixes #5858.

File:

• trunk/tests/phpunit/testcases/blogs/class-bp-blogs-blog.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/blogs/class-bp-blogs-blog.php

@@ -38 +38 @@
 
         $this->set_current_user( $old_user );
+        wpmu_delete_blog( $b, true );
+    }
+
+    /**
+     * @ticket BP5858
+     */
+    public function test_get_with_search_terms_should_match_description() {
+        if ( ! is_multisite() ) {
+            return;
+        }
+
+        $old_user = get_current_user_id();
+
+        $u = $this->factory->user->create();
+        $this->set_current_user( $u );
+        $b = $this->factory->blog->create( array(
+            'title' => 'The Foo Bar Blog',
+            'domain' => __METHOD__,
+            'user_id' => $u,
+        ) );
+        update_blog_option( $b, 'blogdescription', 'Full of foorificness' );
+        bp_blogs_record_existing_blogs();
+
+        // make the blog public or it won't turn up in generic results
+        update_blog_option( $b, 'blog_public', '1' );
+
+        $blogs = BP_Blogs_Blog::get( 'active', false, false, 0, 'Full' );
+        $blog_ids = wp_list_pluck( $blogs['blogs'], 'blog_id' );
+
+        $this->assertEquals( array( $b ), $blog_ids );
+        $this->assertEquals( 1, $blogs['total'] );
+
+        $this->set_current_user( $old_user );
+        wpmu_delete_blog( $b, true );
     }
 
@@ -65 +99 @@
 
         $this->set_current_user( $old_user );
+        wpmu_delete_blog( $b, true );
     }
 
@@ -95 +130 @@
 
         $this->set_current_user( $old_user );
+        wpmu_delete_blog( $b, true );
     }
 }