Changeset 9261

Timestamp:

12/23/2014 11:11:58 AM (12 years ago)

Author:

djpaul

Message:

Core: adjust bp_modify_page_title() so that it can be used safely after the wp_head action.

The function is used to set the value for the page's <title> element, but it currently throws a PHP Notice if it's used after the wp_head action is triggered.
This is because bp_core_sort_subnav_items() (hooked to wp_head) re-keys the global $bp->bp_options_nav array; the keys are changed from strings to integers representing the desired order of the menu items.

Fixes #6077

File:

• trunk/src/bp-core/bp-core-filters.php (modified) (1 diff)

trunk/src/bp-core/bp-core-filters.php

@@ -466 +466 @@
 
                 // Append action name if we're on a member component sub-page
-                if ( ! empty( $bp->bp_options_nav[ $component_id ][ bp_current_action() ]['name'] ) && ! empty( $bp->canonical_stack['action'] ) ) {
-                        $component_subnav_name = "{$bp->bp_options_nav[ $component_id ][ bp_current_action() ]['name']}";
+                if ( ! empty( $bp->bp_options_nav[ $component_id ] ) && ! empty( $bp->canonical_stack['action'] ) ) {
+                        $component_subnav_name = wp_filter_object_list( $bp->bp_options_nav[ $component_id ], array( 'slug' => bp_current_action() ), 'and', 'name' );
+
+                        if ( $component_subnav_name ) {
+                                $component_subnav_name = array_shift( $component_subnav_name );
+                        } else {
+                                $component_subnav_name = '';
+                        }
+
                 } else {
                         $component_subnav_name = '';