Changeset 9231 for trunk/src/bp-groups/bp-groups-functions.php

Timestamp:

12/15/2014 08:38:11 PM (11 years ago)

Author:

r-a-y

Message:

Check cache for count functions that return zero.

Some of our count functions were previously setting counts of zero
correctly, but the functions themselves were not referencing the cache
properly when the count returned zero. This led to unnecessary database
queries and we hate extra queries!

This commit addresses the problem and adds unit tests.

Props r-a-y, boonebgorges.

Fixes #6012.

File:

• trunk/src/bp-groups/bp-groups-functions.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-functions.php

@@ -645 +645 @@
  */
 function groups_get_total_group_count() {
-    if ( !$count = wp_cache_get( 'bp_total_group_count', 'bp' ) ) {
+    $count = wp_cache_get( 'bp_total_group_count', 'bp' );
+
+    if ( false === $count ) {
         $count = BP_Groups_Group::get_total_group_count();
         wp_cache_set( 'bp_total_group_count', $count, 'bp' );
@@ -685 +687 @@
         $user_id = ( bp_displayed_user_id() ) ? bp_displayed_user_id() : bp_loggedin_user_id();
 
-    if ( !$count = wp_cache_get( 'bp_total_groups_for_user_' . $user_id, 'bp' ) ) {
+    $count = wp_cache_get( 'bp_total_groups_for_user_' . $user_id, 'bp' );
+
+    if ( false === $count ) {
         $count = BP_Groups_Member::total_group_count( $user_id );
         wp_cache_set( 'bp_total_groups_for_user_' . $user_id, $count, 'bp' );