Changeset 9230

Timestamp:

12/13/2014 12:43:12 PM (10 years ago)

Author:

boonebgorges

Message:

Don't join against the group members table when fetching total group counts.

The join doesn't take place in the 'paged' count, which leads to inconsistent
query results when groups have no members.

This reverts changes made in [4064].

Props Mamaduka.
Fixes #5584.

File:

• trunk/src/bp-groups/bp-groups-classes.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-classes.php

@@ -782 +782 @@
         $paged_groups     = $wpdb->get_results( $paged_groups_sql );
 
-        $total_sql['select'] = "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name} g, {$bp->groups->table_name_members} gm1, {$bp->groups->table_name_groupmeta} gm2";
+        $total_sql['select'] = "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name} g, {$bp->groups->table_name_groupmeta} gm";
 
         if ( ! empty( $r['user_id'] ) ) {
@@ -821 +821 @@
         }
 
-        $total_sql['where'][] = "g.id = gm1.group_id";
-        $total_sql['where'][] = "g.id = gm2.group_id";
-        $total_sql['where'][] = "gm2.meta_key = 'last_activity'";
+        $total_sql['where'][] = "g.id = gm.group_id";
+        $total_sql['where'][] = "gm.meta_key = 'last_activity'";
 
         $t_sql = $total_sql['select'];