Changeset 9194 for trunk/src/bp-activity/bp-activity-template.php

Timestamp:

11/27/2014 05:13:29 PM (10 years ago)

Author:

imath

Message:

Post Type Activity Tracking feature

So far the tracking feature was requiring the Blogs component to be active. In 2.2 we are centralizing the majority of the tracking code into the Activity component. A new set of functions and hooks has been created to catch public post types supporting the feature 'buddypress-activity' and to automatically generate an activity when a new item is publicly published.

It's now possible to add this support to any public post type using one unique line of code, eg: add_post_type_support( 'page', 'buddypress-activity' ). In this case BuddyPress will use generic activity attributes.
Each activity attribute of the supported post type can be customized using a specific function (eg: set custom strings to describe the post type activity action).

When registering a post type in WordPress it's also possible to set the 'buddypress-activity' feature using the support parameter of the second argument of the register_post_type() function. Custom activity action strings can be defined within the labels parameter and activity attributes can be set using the new parameter 'bp_activity'.

When the Blogs component is active, the 'post' post type is automatically supporting the 'buddypress-activity' feature. The conditional logic (eg: blog_public option set to 1 ...) that occurs before a new activity is posted and the comments tracking remain unchanged.

props boonebgorges, DJPaul

Fixes #5669

File:

• trunk/src/bp-activity/bp-activity-template.php (modified) (3 diffs)

trunk/src/bp-activity/bp-activity-template.php

@@ -3316 +3316 @@
 function bp_activity_can_comment() {
     global $activities_template;
+    $bp = buddypress();
 
     // Assume activity can be commented on
@@ -3322 +3323 @@
     // Determine ability to comment based on activity action name
     $activity_action = bp_get_activity_action_name();
-    switch ( $activity_action ) {
-
-        // Maybe turn off for blog and forum updates
-        case 'new_blog_post'    :
-        case 'new_blog_comment' :
-        case 'new_forum_topic'  :
-        case 'new_forum_post'   :
-            if ( ! empty( $activities_template->disable_blogforum_replies ) ) {
-                $can_comment = false;
-            }
-            break;
-
-        // Turn off for activity comments
-        case 'activity_comment' :
-            $can_comment = false;
-            break;
-    }
+
+    $turn_off = 0;
+    if ( ! empty( $activities_template->disable_blogforum_replies ) ) {
+        $turn_off = 1;
+    }
+
+    $maybe_turn_off = array_fill_keys( array(
+        'new_blog_post',
+        'new_blog_comment',
+        'new_forum_topic',
+        'new_forum_post',
+    ), $turn_off );
+
+    $maybe_turn_off['activity_comment'] = 1;
+
+    // Fetch all the tracked post types once.
+    if ( empty( $bp->activity->track ) ) {
+        $bp->activity->track = bp_activity_get_post_types_tracking_args();
+    }
+
+    foreach ( $bp->activity->track as $action => $tracking_args ) {
+        if ( empty( $tracking_args->activity_comment ) ) {
+            $maybe_turn_off[ $action ] = $turn_off;
+        }
+    }
+
+    $can_comment = empty( $maybe_turn_off[ $activity_action ] );
 
     /**
@@ -4368 +4379 @@
         // Walk through the registered actions, and prepare an the
         // select box options.
-        foreach ( buddypress()->activity->actions as $actions ) {
+        foreach ( bp_activity_get_actions() as $actions ) {
             foreach ( $actions as $action ) {
                 if ( ! in_array( $context, (array) $action['context'] ) ) {