Changeset 9157 for trunk/src/bp-groups/bp-groups-screens.php

Timestamp:

11/21/2014 06:24:16 PM (5 years ago)

Author:

imath

Message:

Remove all links in titles of directory and single item pages

Since BuddyPress 1.7, to display the "Create" buttons (Blogs & Groups component) and links to the single item landing pages at a similar place to BP-Default, BP Theme Compat was adding links into the title of the WordPress post object. For 2.2, team has decided to remove all these links and find a better placement for them before the end of the dev-cycle.

See #6008

File:

• trunk/src/bp-groups/bp-groups-screens.php (modified) (5 diffs)

trunk/src/bp-groups/bp-groups-screens.php

@@ -1100 +1100 @@
      */
     public function directory_dummy_post() {
-
-        $title = apply_filters( 'bp_groups_directory_header', bp_get_directory_title( 'groups' ) );
+        bp_theme_compat_reset_post( array(
+            'ID'             => 0,
+            'post_title'     => bp_get_directory_title( 'groups' ),
+            'post_author'    => 0,
+            'post_date'      => 0,
+            'post_content'   => '',
+            'post_type'      => 'page',
+            'post_status'    => 'publish',
+            'is_page'        => true,
+            'comment_status' => 'closed'
+        ) );
+    }
+
+    /**
+     * Filter the_content with the groups index template part.
+     *
+     * @since BuddyPress (1.7.0)
+     */
+    public function directory_content() {
+        return bp_buffer_template_part( 'groups/index', null, false );
+    }
+
+    /** Create ************************************************************/
+
+    /**
+     * Add custom template hierarchy to theme compat for the group create page.
+     *
+     * This is to mirror how WordPress has
+     * {@link https://codex.wordpress.org/Template_Hierarchy template hierarchy}.
+     *
+     * @since BuddyPress (1.8.0)
+     *
+     * @param string $templates The templates from bp_get_theme_compat_templates().
+     * @return array $templates Array of custom templates to look for.
+     */
+    public function create_template_hierarchy( $templates ) {
+        // Setup our templates based on priority
+        $new_templates = apply_filters( 'bp_template_hierarchy_groups_create', array(
+            'groups/index-create.php'
+        ) );
+
+        // Merge new templates with existing stack
+        // @see bp_get_theme_compat_templates()
+        $templates = array_merge( $new_templates, $templates );
+
+        return $templates;
+    }
+
+    /**
+     * Update the global $post with create screen data.
+     *
+     * @since BuddyPress (1.7.0)
+     */
+    public function create_dummy_post() {
+
+        $title = _x( 'Groups', 'Group creation page', 'buddypress' );
 
         bp_theme_compat_reset_post( array(
@@ -1117 +1171 @@
 
     /**
-     * Filter the_content with the groups index template part.
+     * Filter the_content with the create screen template part.
      *
      * @since BuddyPress (1.7.0)
      */
-    public function directory_content() {
-        return bp_buffer_template_part( 'groups/index', null, false );
-    }
-
-    /** Create ************************************************************/
+    public function create_content() {
+        return bp_buffer_template_part( 'groups/create', null, false );
+    }
+
+    /** Single ************************************************************/
 
     /**
-     * Add custom template hierarchy to theme compat for the group create page.
+     * Add custom template hierarchy to theme compat for group pages.
      *
      * This is to mirror how WordPress has
@@ -1138 +1192 @@
      * @return array $templates Array of custom templates to look for.
      */
-    public function create_template_hierarchy( $templates ) {
+    public function single_template_hierarchy( $templates ) {
+        // Setup some variables we're going to reference in our custom templates
+        $group = groups_get_current_group();
+
         // Setup our templates based on priority
-        $new_templates = apply_filters( 'bp_template_hierarchy_groups_create', array(
-            'groups/index-create.php'
+        $new_templates = apply_filters( 'bp_template_hierarchy_groups_single_item', array(
+            'groups/single/index-id-'     . sanitize_file_name( bp_get_current_group_id() )   . '.php',
+            'groups/single/index-slug-'   . sanitize_file_name( bp_get_current_group_slug() ) . '.php',
+            'groups/single/index-action-' . sanitize_file_name( bp_current_action() )         . '.php',
+            'groups/single/index-status-' . sanitize_file_name( $group->status )              . '.php',
+            'groups/single/index.php'
         ) );
 
         // Merge new templates with existing stack
         // @see bp_get_theme_compat_templates()
-        $templates = array_merge( $new_templates, $templates );
+        $templates = array_merge( (array) $new_templates, $templates );
 
         return $templates;
@@ -1152 +1213 @@
 
     /**
-     * Update the global $post with create screen data.
+     * Update the global $post with single group data.
      *
      * @since BuddyPress (1.7.0)
      */
-    public function create_dummy_post() {
-
-        $title = _x( 'Groups', 'Group creation page', 'buddypress' );
-
+    public function single_dummy_post() {
         bp_theme_compat_reset_post( array(
             'ID'             => 0,
-            'post_title'     => $title,
+            'post_title'     => bp_get_current_group_name(),
             'post_author'    => 0,
             'post_date'      => 0,
@@ -1174 +1232 @@
 
     /**
-     * Filter the_content with the create screen template part.
-     *
-     * @since BuddyPress (1.7.0)
-     */
-    public function create_content() {
-        return bp_buffer_template_part( 'groups/create', null, false );
-    }
-
-    /** Single ************************************************************/
-
-    /**
-     * Add custom template hierarchy to theme compat for group pages.
-     *
-     * This is to mirror how WordPress has
-     * {@link https://codex.wordpress.org/Template_Hierarchy template hierarchy}.
-     *
-     * @since BuddyPress (1.8.0)
-     *
-     * @param string $templates The templates from bp_get_theme_compat_templates().
-     * @return array $templates Array of custom templates to look for.
-     */
-    public function single_template_hierarchy( $templates ) {
-        // Setup some variables we're going to reference in our custom templates
-        $group = groups_get_current_group();
-
-        // Setup our templates based on priority
-        $new_templates = apply_filters( 'bp_template_hierarchy_groups_single_item', array(
-            'groups/single/index-id-'     . sanitize_file_name( bp_get_current_group_id() )   . '.php',
-            'groups/single/index-slug-'   . sanitize_file_name( bp_get_current_group_slug() ) . '.php',
-            'groups/single/index-action-' . sanitize_file_name( bp_current_action() )         . '.php',
-            'groups/single/index-status-' . sanitize_file_name( $group->status )              . '.php',
-            'groups/single/index.php'
-        ) );
-
-        // Merge new templates with existing stack
-        // @see bp_get_theme_compat_templates()
-        $templates = array_merge( (array) $new_templates, $templates );
-
-        return $templates;
-    }
-
-    /**
-     * Update the global $post with single group data.
-     *
-     * @since BuddyPress (1.7.0)
-     */
-    public function single_dummy_post() {
-        bp_theme_compat_reset_post( array(
-            'ID'             => 0,
-            'post_title'     => '<a href="' . bp_get_group_permalink( groups_get_current_group() ) . '">' . bp_get_current_group_name() . '</a>',
-            'post_author'    => 0,
-            'post_date'      => 0,
-            'post_content'   => '',
-            'post_type'      => 'page',
-            'post_status'    => 'publish',
-            'is_page'        => true,
-            'comment_status' => 'closed'
-        ) );
-    }
-
-    /**
      * Filter the_content with the single group template part.
      *