Changeset 9139 for trunk/tests/phpunit/testcases/xprofile/activity.php

Timestamp:

11/14/2014 02:01:18 PM (10 years ago)

Author:

boonebgorges

Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:

• trunk/tests/phpunit/testcases/xprofile/activity.php (modified) (5 diffs)

trunk/tests/phpunit/testcases/xprofile/activity.php

@@ -278 +278 @@
      */
     public function test_bp_xprofile_format_activity_action_new_avatar() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $a = $this->factory->activity->create( array(
             'component' => 'profile',
@@ -300 +300 @@
         buddypress()->active_components['xprofile'] = '1';
 
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $a = $this->factory->activity->create( array(
             'component' => buddypress()->profile->id,
@@ -326 +326 @@
         unset( buddypress()->active_components['xprofile'] );
 
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $a = $this->factory->activity->create( array(
             'component' => buddypress()->profile->id,
@@ -349 +349 @@
      */
     public function test_bp_xprofile_format_activity_action_updated_profile() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $a = $this->factory->activity->create( array(
             'component' => buddypress()->profile->id,
@@ -364 +364 @@
 
     protected function setup_updated_profile_data() {
-        $this->updated_profile_data['u'] = $this->create_user();
+        $this->updated_profile_data['u'] = $this->factory->user->create();
         $this->updated_profile_data['g'] = $this->factory->xprofile_group->create();
         $this->updated_profile_data['f'] = $this->factory->xprofile_field->create( array(