Changeset 9139 for trunk/tests/phpunit/testcases/notifications/functions.php

Timestamp:

11/14/2014 02:01:18 PM (10 years ago)

Author:

boonebgorges

Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:

• trunk/tests/phpunit/testcases/notifications/functions.php (modified) (4 diffs)

trunk/tests/phpunit/testcases/notifications/functions.php

@@ -6 +6 @@
 class BP_Tests_Notifications_Functions extends BP_UnitTestCase {
     public function test_cache_invalidation_all_for_user_on_save() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $n1 = $this->factory->notification->create( array(
             'component_name' => 'groups',
@@ -34 +34 @@
 
     public function test_cache_invalidation_all_for_user_on_delete() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $n1 = $this->factory->notification->create( array(
             'component_name' => 'groups',
@@ -97 +97 @@
      */
     public function test_bp_notifications_get_unread_notification_count_cache() {
-        $u1 = $this->create_user();
-        $u2 = $this->create_user();
+        $u1 = $this->factory->user->create();
+        $u2 = $this->factory->user->create();
 
         $n1 = $this->factory->notification->create( array(
@@ -126 +126 @@
      */
     public function test_bp_has_notifications_filtering() {
-        $u1 = $this->create_user();
-        $u2 = $this->create_user();
+        $u1 = $this->factory->user->create();
+        $u2 = $this->factory->user->create();
 
         // create a mixture of different notifications