Changeset 9139 for trunk/tests/phpunit/testcases/messages/class.bp-messages-notice.php

Timestamp:

11/14/2014 02:01:18 PM (10 years ago)

Author:

boonebgorges

Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:

• trunk/tests/phpunit/testcases/messages/class.bp-messages-notice.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/messages/class.bp-messages-notice.php

@@ -11 +11 @@
         parent::setUp();
         $this->old_current_user = get_current_user_id();
-        $this->set_current_user( $this->create_user( array( 'role' => 'administrator' ) ) );
+        $this->set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
     }
 
@@ -44 +44 @@
         // now get the new active notice
         BP_Messages_Notice::get_active();
-        
+
         // grab the cache and make sure it equals our new notice
         $cache = wp_cache_get( 'active_notice', 'bp_messages' );