Changeset 9139 for trunk/tests/phpunit/testcases/members/template.php

Timestamp:

11/14/2014 02:01:18 PM (12 years ago)

Author:

boonebgorges

Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:

• trunk/tests/phpunit/testcases/members/template.php (modified) (4 diffs)

trunk/tests/phpunit/testcases/members/template.php

@@ -21 +21 @@
 
         public function test_bp_has_members_include_on_user_page() {
-                $u1 = $this->create_user();
-                $u2 = $this->create_user();
+                $u1 = $this->factory->user->create();
+                $u2 = $this->factory->user->create();
 
                 $this->go_to( bp_core_get_user_domain( $u1 ) );
@@ -46 +46 @@
          */
         public function test_bp_has_members_search_pagination_with_spaces() {
-                $u1 = $this->create_user( array( 'display_name' => '~ tilde u1' ) );
-                $u2 = $this->create_user( array( 'display_name' => '~ tilde u2' ) );
+                $u1 = $this->factory->user->create( array( 'display_name' => '~ tilde u1' ) );
+                $u2 = $this->factory->user->create( array( 'display_name' => '~ tilde u2' ) );
 
                 $template_args = array(
@@ -68 +68 @@
 
         public function test_bp_has_members_friendship_requests() {
-                $u1 = $this->create_user();
-                $u2 = $this->create_user();
+                $u1 = $this->factory->user->create();
+                $u2 = $this->factory->user->create();
 
                 friends_add_friend( $u1, $u2 );
@@ -97 +97 @@
          */
         public function test_bp_has_members_friendship_requests_with_no_requests() {
-                $u1 = $this->create_user();
-                $u2 = $this->create_user();
+                $u1 = $this->factory->user->create();
+                $u2 = $this->factory->user->create();
 
                 $old_user = get_current_user_id();