Changeset 9139 for trunk/tests/phpunit/testcases/members/functions.php

Timestamp:

11/14/2014 02:01:18 PM (10 years ago)

Author:

boonebgorges

Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:

• trunk/tests/phpunit/testcases/members/functions.php (modified) (11 diffs)

trunk/tests/phpunit/testcases/members/functions.php

@@ -96 +96 @@
      */
     public function test_bp_core_get_user_displayname_translate_username() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
 
         $user = new WP_User( $u );
@@ -120 +120 @@
         buddypress()->active_components['xprofile'] = '1';
 
-        $u = $this->create_user( array(
+        $u = $this->factory->user->create( array(
             'display_name' => 'Foo',
         ) );
@@ -140 +140 @@
         buddypress()->active_components['xprofile'] = '1';
 
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         xprofile_set_field_data( 1, $u, 'Foo Foo' );
 
@@ -157 +157 @@
         buddypress()->active_components['xprofile'] = '1';
 
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         xprofile_set_field_data( 1, $u, 'Foo Foo' );
 
@@ -174 +174 @@
         buddypress()->active_components['xprofile'] = '1';
 
-        $u = $this->create_user( array(
+        $u = $this->factory->user->create( array(
             'display_name' => 'Foo Foo',
         ) );
@@ -205 +205 @@
      */
     public function test_bp_core_get_user_displaynames_all_uncached() {
-        $u1 = $this->create_user();
-        $u2 = $this->create_user();
+        $u1 = $this->factory->user->create();
+        $u2 = $this->factory->user->create();
 
         xprofile_set_field_data( 1, $u1, 'Foo' );
@@ -223 +223 @@
      */
     public function test_bp_core_get_user_displaynames_one_not_in_xprofile() {
-        $u1 = $this->create_user();
-        $u2 = $this->create_user( array(
+        $u1 = $this->factory->user->create();
+        $u2 = $this->factory->user->create( array(
             'display_name' => 'Bar',
         ) );
@@ -249 +249 @@
      */
     public function test_bp_core_get_user_displaynames_one_in_cache() {
-        $u1 = $this->create_user();
+        $u1 = $this->factory->user->create();
         xprofile_set_field_data( 1, $u1, 'Foo' );
 
@@ -268 +268 @@
      */
     public function test_bp_members_migrate_signups_standard() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $u_obj = new WP_User( $u );
 
@@ -302 +302 @@
      */
     public function test_bp_members_migrate_signups_activation_key_but_user_status_0() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $u_obj = new WP_User( $u );
 
@@ -333 +333 @@
      */
     public function test_bp_members_migrate_signups_no_activation_key_but_user_status_2() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $u_obj = new WP_User( $u );