Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
11/14/2014 02:01:18 PM (10 years ago)
Author:
boonebgorges
Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/groups/activity.php

    r8958 r9139  
    1111     */
    1212    public function test_bp_groups_format_activity_action_created_group() {
    13         $u = $this->create_user();
     13        $u = $this->factory->user->create();
    1414        $g = $this->factory->group->create();
    1515        $a = $this->factory->activity->create( array(
     
    3333     */
    3434    public function test_bp_groups_format_activity_action_joined_group() {
    35         $u = $this->create_user();
     35        $u = $this->factory->user->create();
    3636        $g = $this->factory->group->create();
    3737        $a = $this->factory->activity->create( array(
Note: See TracChangeset for help on using the changeset viewer.