Changeset 9139 for trunk/tests/phpunit/testcases/core/class-bp-button.php

Timestamp:

11/14/2014 02:01:18 PM (10 years ago)

Author:

boonebgorges

Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:

• trunk/tests/phpunit/testcases/core/class-bp-button.php (modified) (5 diffs)

trunk/tests/phpunit/testcases/core/class-bp-button.php

@@ -22 +22 @@
      */
     public function test_block_self_own_profile() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $this->set_current_user( $u );
 
@@ -40 +40 @@
      */
     public function test_block_self_others_profile() {
-        $u1 = $this->create_user();
+        $u1 = $this->factory->user->create();
         $this->set_current_user( $u1 );
 
-        $u2 = $this->create_user();
+        $u2 = $this->factory->user->create();
         $this->go_to( bp_core_get_user_domain( $u2 ) );
 
@@ -60 +60 @@
     public function test_block_self_inside_members_loop() {
         $now = time();
-        $u1 = $this->create_user( array(
+        $u1 = $this->factory->user->create( array(
             'last_activity' => date( 'Y-m-d H:i:s', $now ),
         ) );
-        $u2 = $this->create_user( array(
+        $u2 = $this->factory->user->create( array(
             'last_activity' => date( 'Y-m-d H:i:s', $now - 100 ),
         ) );
@@ -100 +100 @@
     public function test_block_self_false_inside_members_loop() {
         $now = time();
-        $u1 = $this->create_user( array(
+        $u1 = $this->factory->user->create( array(
             'last_activity' => date( 'Y-m-d H:i:s', $now ),
         ) );
-        $u2 = $this->create_user( array(
+        $u2 = $this->factory->user->create( array(
             'last_activity' => date( 'Y-m-d H:i:s', $now - 100 ),
         ) );
@@ -140 +140 @@
     public function test_block_self_inside_members_loop_on_my_profile_page() {
         $now = time();
-        $u1 = $this->create_user( array(
+        $u1 = $this->factory->user->create( array(
             'last_activity' => date( 'Y-m-d H:i:s', $now ),
         ) );
-        $u2 = $this->create_user( array(
+        $u2 = $this->factory->user->create( array(
             'last_activity' => date( 'Y-m-d H:i:s', $now - 100 ),
         ) );