Changeset 9139 for trunk/tests/phpunit/testcases/activity/functions.php

Timestamp:

11/14/2014 02:01:18 PM (10 years ago)

Author:

boonebgorges

Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:

• trunk/tests/phpunit/testcases/activity/functions.php (modified) (12 diffs)

trunk/tests/phpunit/testcases/activity/functions.php

@@ -453 +453 @@
         add_filter( 'bp_is_username_compatibility_mode', '__return_false' );
 
-        $u = $this->create_user( array(
+        $u = $this->factory->user->create( array(
             'user_login' => 'foo bar baz',
             'user_nicename' => 'foo-bar-baz',
@@ -469 +469 @@
         add_filter( 'bp_is_username_compatibility_mode', '__return_true' );
 
-        $u1 = $this->create_user( array(
+        $u1 = $this->factory->user->create( array(
             'user_login' => 'foo bar baz',
             'user_nicename' => 'foo-bar-baz',
         ) );
 
-        $u2 = $this->create_user( array(
+        $u2 = $this->factory->user->create( array(
             'user_login' => 'foo.bar.baz',
             'user_nicename' => 'foo-bar-baz',
@@ -491 +491 @@
         add_filter( 'bp_is_username_compatibility_mode', '__return_false' );
 
-        $u = $this->create_user( array(
+        $u = $this->factory->user->create( array(
             'user_login' => 'foo bar baz',
             'user_nicename' => 'foo-bar-baz',
@@ -508 +508 @@
 
         // all spaces are hyphens
-        $u1 = $this->create_user( array(
+        $u1 = $this->factory->user->create( array(
             'user_login' => 'foo bar baz',
             'user_nicename' => 'foobarbaz',
@@ -514 +514 @@
 
         // no spaces are hyphens
-        $u2 = $this->create_user( array(
+        $u2 = $this->factory->user->create( array(
             'user_login' => 'foo-bar-baz-1',
             'user_nicename' => 'foobarbaz-1',
@@ -520 +520 @@
 
         // some spaces are hyphens
-        $u3 = $this->create_user( array(
+        $u3 = $this->factory->user->create( array(
             'user_login' => 'foo bar-baz 2',
             'user_nicename' => 'foobarbaz-2',
         ) );
 
-        $u4 = $this->create_user( array(
+        $u4 = $this->factory->user->create( array(
             'user_login' => 'foo.bar.baz',
             'user_nicename' => 'foo-bar-baz',
@@ -543 +543 @@
      */
     public function test_bp_activity_format_activity_action_activity_update() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $a = $this->factory->activity->create( array(
             'component' => buddypress()->activity->id,
@@ -562 +562 @@
      */
     public function test_bp_activity_format_activity_action_activity_comment() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $a = $this->factory->activity->create( array(
             'component' => buddypress()->activity->id,
@@ -747 +747 @@
      */
     public function test_add_user_favorite_already_favorited() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $a = $this->factory->activity->create();
 
@@ -762 +762 @@
      */
     public function test_add_user_favorite_not_yet_favorited() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
         $a = $this->factory->activity->create();
         $this->assertTrue( bp_activity_add_user_favorite( $a, $u ) );
@@ -772 +772 @@
      */
     public function test_remove_user_favorite_bad_activity_id() {
-        $u1 = $this->create_user();
-        $u2 = $this->create_user();
+        $u1 = $this->factory->user->create();
+        $u2 = $this->factory->user->create();
         $a = $this->factory->activity->create();
 
@@ -805 +805 @@
      */
     public function test_bp_activity_post_update_success() {
-        $u = $this->create_user();
+        $u = $this->factory->user->create();
 
         $a = bp_activity_post_update( array(