Changeset 9139 for trunk/tests/phpunit/includes/factory.php

Timestamp:

11/14/2014 02:01:18 PM (10 years ago)

Author:

boonebgorges

Message:

In automated tests, move user creation to a proper factory method.

BP user creation requires that a couple of extra pieces of data be set up
(last activity, display name, etc). So we previously had a wrapper in
BP_UnitTestCase called create_user() that performed the extra setup.
However, the wrapper made it impossible to use create_user() statically,
because the user_login and user_email iterator was not persistent from call to
call. (The create_user() syntax is also a break with the rest of our unit
tests, which is not ideal.)

This changeset introduces BP_UnitTest_Factory_For_User, which reproduces the
customizations of create_user(), but in a proper factory method. All
instances of create_user() throughout the test suite have also been replaced.

See #6009.

File:

• trunk/tests/phpunit/includes/factory.php (modified) (2 diffs)

trunk/tests/phpunit/includes/factory.php

@@ -6 +6 @@
         parent::__construct();
 
+        $this->user = new BP_UnitTest_Factory_For_User( $this );
         $this->activity = new BP_UnitTest_Factory_For_Activity( $this );
         $this->group = new BP_UnitTest_Factory_For_Group( $this );
@@ -16 +17 @@
 }
 
+class BP_UnitTest_Factory_For_User extends WP_UnitTest_Factory_For_User {
+    /**
+     * When creating a new user, it's almost always necessary to have the
+     * last_activity usermeta set right away, so that the user shows up in
+     * directory queries. This is a shorthand wrapper for the user factory
+     * create() method.
+     *
+     * Also set a display name
+     */
+    public function create_object( $args ) {
+        $r = wp_parse_args( $args, array(
+            'role' => 'subscriber',
+            'last_activity' => date( 'Y-m-d H:i:s', strtotime( bp_core_current_time() ) - 60*60*24*365 ),
+        ) );
+
+        $last_activity = $r['last_activity'];
+        unset( $r['last_activity'] );
+
+        $user_id = wp_insert_user( $r );
+
+        bp_update_user_last_activity( $user_id, $last_activity );
+
+        if ( bp_is_active( 'xprofile' ) ) {
+            $user = new WP_User( $user_id );
+            xprofile_set_field_data( 1, $user_id, $user->display_name );
+        }
+
+        return $user_id;
+    }
+}
+
 class BP_UnitTest_Factory_For_Activity extends WP_UnitTest_Factory_For_Thing {