Changeset 9128

Timestamp:

11/10/2014 03:37:06 PM (12 years ago)

Author:

boonebgorges

Message:

Don't show Settings > Email tab when there's nothing to display there.

Props Mamaduka.
Fixes #5441.

Location:

trunk/src/bp-settings

Files:

• bp-settings-actions.php (modified) (1 diff)
• bp-settings-loader.php (modified) (1 diff)

trunk/src/bp-settings/bp-settings-actions.php

@@ -466 +466 @@
 }
 add_action( 'bp_actions', 'bp_settings_verify_email_change' );
+
+/**
+ * Removes 'Email' sub nav, if no component has registered options there.
+ *
+ * @since BuddyPress (2.2.0)
+ */
+function bp_settings_remove_email_subnav() {
+        if ( ! has_action( 'bp_notification_settings' ) ) {
+                bp_core_remove_subnav_item( BP_SETTINGS_SLUG, 'notifications' );
+        }
+}
+add_action( 'bp_actions', 'bp_settings_remove_email_subnav' );

trunk/src/bp-settings/bp-settings-loader.php

@@ -173 +173 @@
                         );
 
-                        // Notifications
-                        $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-notifications',
-                                'title'  => __( 'Email', 'buddypress' ),
-                                'href'   => trailingslashit( $settings_link . 'notifications' )
-                        );
+                        // Notifications - only add the tab when there is something to display there.
+                        if ( has_action( 'bp_notification_settings' ) ) {
+                                $wp_admin_nav[] = array(
+                                        'parent' => 'my-account-' . $this->id,
+                                        'id'     => 'my-account-' . $this->id . '-notifications',
+                                        'title'  => __( 'Email', 'buddypress' ),
+                                        'href'   => trailingslashit( $settings_link . 'notifications' )
+                                );
+                        }
 
                         // Delete Account