Changeset 9127 for trunk/src/bp-groups/bp-groups-template.php

Timestamp:

11/07/2014 11:31:26 PM (10 years ago)

Author:

imath

Message:

Improve the way Group's Manage tabs are generated

In BP_Group_Extension->setup_edit_hooks() method, we are now using the bp_core_new_subnav_item() function to generate the Group's manage tab sub navigation.
The action 'groups_admin_tabs' is no more used. However for back compatibility reasons, we will keep on catching this hook inviting the user using a _doing_it_wrong message to now use the BuddyPress Group Extension API instead.

props boonebgorges

Fixes #5994

File:

• trunk/src/bp-groups/bp-groups-template.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-template.php

@@ -2300 +2300 @@
     }
 
-    $current_tab = bp_get_group_current_admin_tab();
-
-    if ( bp_is_item_admin() ) : ?>
-
-        <li<?php if ( 'edit-details' == $current_tab || empty( $current_tab ) ) : ?> class="current"<?php endif; ?>><a href="<?php echo trailingslashit( bp_get_group_permalink( $group ) . 'admin/edit-details' ) ?>"><?php _e( 'Details', 'buddypress' ); ?></a></li>
-
-    <?php endif; ?>
-
-    <?php if ( ! bp_is_item_admin() )
-            return false; ?>
-
-    <li<?php if ( 'group-settings' == $current_tab ) : ?> class="current"<?php endif; ?>><a href="<?php echo trailingslashit( bp_get_group_permalink( $group ) . 'admin/group-settings' ) ?>"><?php _e( 'Settings', 'buddypress' ); ?></a></li>
-
-    <?php if ( !(int)bp_get_option( 'bp-disable-avatar-uploads' ) && buddypress()->avatar->show_avatars ) : ?>
-
-        <li<?php if ( 'group-avatar'   == $current_tab ) : ?> class="current"<?php endif; ?>><a href="<?php echo trailingslashit( bp_get_group_permalink( $group ) . 'admin/group-avatar' ) ?>"><?php _e( 'Photo', 'buddypress' ); ?></a></li>
-
-    <?php endif; ?>
-
-    <li<?php if ( 'manage-members' == $current_tab ) : ?> class="current"<?php endif; ?>><a href="<?php echo trailingslashit( bp_get_group_permalink( $group ) . 'admin/manage-members' ) ?>"><?php _e( 'Members', 'buddypress' ); ?></a></li>
-
-    <?php if ( $groups_template->group->status == 'private' ) : ?>
-
-        <li<?php if ( 'membership-requests' == $current_tab ) : ?> class="current"<?php endif; ?>><a href="<?php echo trailingslashit( bp_get_group_permalink( $group ) . 'admin/membership-requests' ) ?>"><?php _e( 'Requests', 'buddypress' ); ?></a></li>
-
-    <?php endif; ?>
-
-    <?php do_action( 'groups_admin_tabs', $current_tab, $group->slug ) ?>
-
-    <li<?php if ( 'delete-group' == $current_tab ) : ?> class="current"<?php endif; ?>><a href="<?php echo trailingslashit( bp_get_group_permalink( $group ) . 'admin/delete-group' ) ?>"><?php _e( 'Delete', 'buddypress' ); ?></a></li>
-
-<?php
+    $css_id = 'manage-members';
+
+    if ( 'private' == $group->status ) {
+        $css_id = 'membership-requests';
+    }
+
+    add_filter( "bp_get_options_nav_{$css_id}", 'bp_group_admin_tabs_backcompat', 10, 3 );
+
+    bp_get_options_nav( $group->slug . '_manage' );
+
+    remove_filter( "bp_get_options_nav_{$css_id}", 'bp_group_admin_tabs_backcompat', 10, 3 );
+}
+
+/**
+ * BackCompat for plugins/themes directly hooking groups_admin_tabs
+ * without using the Groups Extension API
+ *
+ * @param  string $subnav_output subnav item output
+ * @param  string $subnav_item   subnav item params
+ * @param  string $selected_item current selected tab
+ * @return string HTML output
+ */
+function bp_group_admin_tabs_backcompat( $subnav_output = '', $subnav_item = '', $selected_item = '' ) {
+    if ( ! has_action( 'groups_admin_tabs' ) ) {
+        return $subnav_output;
+    }
+
+    $group = groups_get_current_group();
+
+    ob_start();
+
+    do_action( 'groups_admin_tabs', $selected_item, $group->slug );
+
+    $admin_tabs_backcompat = trim( ob_get_contents() );
+    ob_end_clean();
+
+    if ( ! empty( $admin_tabs_backcompat ) ) {
+        _doing_it_wrong( "do_action( 'groups_admin_tabs' )", __( 'This action should not be used directly. Please use the BuddyPress Group Extension API to generate Manage tabs.', 'buddypress' ), '2.2.0' );
+        $subnav_output .= $admin_tabs_backcompat;
+    }
+
+    return $subnav_output;
 }