Changeset 9127 for trunk/src/bp-groups/bp-groups-classes.php

Timestamp:

11/07/2014 11:31:26 PM (10 years ago)

Author:

imath

Message:

Improve the way Group's Manage tabs are generated

In BP_Group_Extension->setup_edit_hooks() method, we are now using the bp_core_new_subnav_item() function to generate the Group's manage tab sub navigation.
The action 'groups_admin_tabs' is no more used. However for back compatibility reasons, we will keep on catching this hook inviting the user using a _doing_it_wrong message to now use the BuddyPress Group Extension API instead.

props boonebgorges

Fixes #5994

File:

• trunk/src/bp-groups/bp-groups-classes.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-classes.php

@@ -3638 +3638 @@
      */
     protected function setup_edit_hooks() {
+        // Bail if not in a group
+        if ( ! bp_is_group() ) {
+            return;
+        }
 
         // Bail if not an edit screen
@@ -3647 +3651 @@
 
         $position = isset( $screen['position'] ) ? (int) $screen['position'] : 10;
-
-        // Add the tab
-        // @todo BP should be using bp_core_new_subnav_item()
-        add_action( 'groups_admin_tabs', create_function( '$current, $group_slug',
-            '$selected = "";
-            if ( "' . esc_attr( $screen['slug'] ) . '" == $current )
-                $selected = " class=\"current\"";
-            echo "<li{$selected}><a href=\"' . trailingslashit( bp_get_root_domain() . '/' . bp_get_groups_root_slug() . '/{$group_slug}/admin/' . esc_attr( $screen['slug'] ) ) . '\">' . esc_attr( $screen['name'] ) . '</a></li>";'
-        ), $position, 2 );
+        $position += 40;
+
+        $current_group = groups_get_current_group();
+        $admin_link = trailingslashit( bp_get_group_permalink( $current_group ) . 'admin' );
+
+        // Add the tab to the manage navigation
+        bp_core_new_subnav_item( array(
+            'name'            => $screen['name'],
+            'slug'            => $screen['slug'],
+            'parent_slug'     => $current_group->slug . '_manage',
+            'parent_url'      => trailingslashit( bp_get_group_permalink( $current_group ) . 'admin' ),
+            'user_has_access' => bp_is_item_admin(),
+            'position'        => $position,
+            'screen_function' => 'groups_screen_group_admin',
+        ) );
 
         // Catch the edit screen and forward it to the plugin template