Changeset 9127 for trunk/src/bp-core/bp-core-template.php

Timestamp:

11/07/2014 11:31:26 PM (11 years ago)

Author:

imath

Message:

Improve the way Group's Manage tabs are generated

In BP_Group_Extension->setup_edit_hooks() method, we are now using the bp_core_new_subnav_item() function to generate the Group's manage tab sub navigation.
The action 'groups_admin_tabs' is no more used. However for back compatibility reasons, we will keep on catching this hook inviting the user using a _doing_it_wrong message to now use the BuddyPress Group Extension API instead.

props boonebgorges

Fixes #5994

File:

• trunk/src/bp-core/bp-core-template.php (modified) (6 diffs)

trunk/src/bp-core/bp-core-template.php

@@ -27 +27 @@
  *       viewed user.
  */
-function bp_get_options_nav() {
+function bp_get_options_nav( $parent_slug = '' ) {
     $bp = buddypress();
 
@@ -33 +33 @@
     // component as an index. Otherwise we need to use the component's root_slug
     $component_index = !empty( $bp->displayed_user ) ? bp_current_component() : bp_get_root_slug( bp_current_component() );
+    $selected_item   = bp_current_action();
 
     if ( ! bp_is_single_item() ) {
@@ -41 +42 @@
         }
     } else {
-        if ( !isset( $bp->bp_options_nav[bp_current_item()] ) || count( $bp->bp_options_nav[bp_current_item()] ) < 1 ) {
+        $current_item = bp_current_item();
+
+        if ( ! empty( $parent_slug ) ) {
+            $current_item  = $parent_slug;
+            $selected_item = bp_action_variable( 0 );
+        }
+
+        if ( !isset( $bp->bp_options_nav[$current_item] ) || count( $bp->bp_options_nav[$current_item] ) < 1 ) {
             return false;
         } else {
-            $the_index = bp_current_item();
+            $the_index = $current_item;
         }
     }
@@ -55 +63 @@
 
         // If the current action or an action variable matches the nav item id, then add a highlight CSS class.
-        if ( $subnav_item['slug'] == bp_current_action() ) {
+        if ( $subnav_item['slug'] == $selected_item ) {
             $selected = ' class="current selected"';
         } else {
@@ -65 +73 @@
 
         // echo out the final list item
-        echo apply_filters( 'bp_get_options_nav_' . $subnav_item['css_id'], '<li id="' . $subnav_item['css_id'] . '-' . $list_type . '-li" ' . $selected . '><a id="' . $subnav_item['css_id'] . '" href="' . $subnav_item['link'] . '">' . $subnav_item['name'] . '</a></li>', $subnav_item );
+        echo apply_filters( 'bp_get_options_nav_' . $subnav_item['css_id'], '<li id="' . $subnav_item['css_id'] . '-' . $list_type . '-li" ' . $selected . '><a id="' . $subnav_item['css_id'] . '" href="' . $subnav_item['link'] . '">' . $subnav_item['name'] . '</a></li>', $subnav_item, $selected_item );
     }
 }
@@ -1918 +1926 @@
         $retval = bp_is_groups_component() && groups_get_current_group();
     }
-    
+
     return (bool) $retval;
 }