Changeset 9125 for trunk/tests/phpunit/testcases/core/avatars.php

Timestamp:

11/05/2014 03:22:56 PM (12 years ago)

Author:

boonebgorges

Message:

Don't extract() in bp_core_fetch_avatar(), and pass params to 'bp_core_fetch_avatar_no_grav' hook.

Passing the modified parameters to the hook required moving away from the use
of extract(). See #5698.

Props dcavins.
Fixes #5958.

File:

• trunk/tests/phpunit/testcases/core/avatars.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/core/avatars.php

@@ -6 +6 @@
 class BP_Tests_Avatars extends BP_UnitTestCase {
     protected $old_current_user = 0;
+
+    private $params = array();
 
     public function setUp() {
@@ -111 +113 @@
         return 'foo';
     }
+
+    /**
+     * @group bp_core_fetch_avatar
+     */
+    public function test_bp_core_fetch_avatar_parameter_conservation() {
+        // First, run the check with custom parameters, specifying no gravatar.
+        $this->params = array(
+            'item_id'    => 1406,
+            'object'     => 'custom_object',
+            'type'       => 'full',
+            'avatar_dir' => 'custom-dir',
+            'width'      => 48,
+            'height'     => 54,
+            'class'      => 'custom-class',
+            'css_id'     => 'custom-css-id',
+            'alt'        => 'custom alt',
+            'email'      => 'avatar@avatar.org',
+            'no_grav'    => true,
+            'html'       => true,
+            'title'      => 'custom-title',
+        );
+
+        // Check to make sure the custom parameters survived the function all the way up to output
+        add_filter( 'bp_core_fetch_avatar', array( $this, 'bp_core_fetch_avatar_filter_check' ), 12, 2 );
+        $avatar = bp_core_fetch_avatar( $this->params );
+
+        // Re-run check, allowing gravatars.
+        $this->params['no_grav'] = false;
+        $avatar = bp_core_fetch_avatar( $this->params );
+
+        remove_filter( 'bp_core_fetch_avatar', array( $this, 'bp_core_fetch_avatar_filter_check' ), 12, 2 );
+
+        unset( $this->params );
+    }
+
+    public function bp_core_fetch_avatar_filter_check( $html, $params ) {
+        // Check that the passed parameters match the original custom parameters.
+        $this->assertEmpty( array_merge( array_diff( $params, $this->params ), array_diff( $this->params, $params ) ) );
+
+        // Check the returned html to see that it matches an expected value.
+        // Get the correct default avatar, based on whether gravatars are allowed.
+        if ( $params['no_grav'] ) {
+            $avatar_url = bp_core_avatar_default( 'local' );
+        } else {
+            // This test has the slight odor of hokum since it recreates so much code that could be changed at any time.
+            $bp = buddypress();
+            // Set host based on if using ssl
+            $host = 'http://gravatar.com/avatar/';
+            if ( is_ssl() ) {
+                $host = 'https://secure.gravatar.com/avatar/';
+            }
+            // Set expected gravatar type
+            if ( empty( $bp->grav_default->{$this->params['object']} ) ) {
+                $default_grav = 'wavatar';
+            } else if ( 'mystery' == $bp->grav_default->{$this->params['object']} ) {
+                $default_grav = apply_filters( 'bp_core_mysteryman_src', 'mm', $this->params['width'] );
+            } else {
+                $default_grav = $bp->grav_default->{$this->params['object']};
+            }
+
+            $avatar_url = $host . md5( strtolower( $this->params['email'] ) ) . '?d=' . $default_grav . '&s=' . $this->params['width'];
+
+            // Gravatar rating; http://bit.ly/89QxZA
+            $rating = get_option( 'avatar_rating' );
+            if ( ! empty( $rating ) ) {
+                $avatar_url .= "&r={$rating}";
+            }
+        }
+
+        $expected_html = '<img src="' . $avatar_url . '" id="' . $this->params['css_id'] . '" class="' . $this->params['class'] . ' ' . $this->params['object'] . '-' . $this->params['item_id'] . '-avatar avatar-' . $this->params['width'] . ' photo" width="' . $this->params['width'] . '" height="' . $this->params['height'] . '" alt="' . $this->params['alt'] . '" title="' . $this->params['title'] . '" />';
+
+        $this->assertEquals( $html, $expected_html );
+    }
 }