Changeset 9121

Timestamp:

11/03/2014 06:26:26 PM (10 years ago)

Author:

djpaul

Message:

Groups, Unit Tests: a creator_id must be passed to groups_create_group to create a group.

Some of our unit tests were built to assume that they would always run with an authenticated user, but obviously this was incorrect. As a result, Groups were being created with creator_id=0, which was breaking other parts of the codebase, for certain tests.

This change also removes the test_creating_new_group_as_anonymous_user test that I added in r9118 which is now unnecessary.

See r9117, r9118, r9120 for other parts of this fix.
Fixes #5983 and the unit tests. :)

Location:

trunk

Files:

• src/bp-groups/bp-groups-functions.php (modified) (1 diff)
• tests/phpunit/testcases/groups/functions.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-functions.php

@@ -121 +121 @@
 
     // Set creator ID
-    if ( ! empty( $creator_id ) ) {
+    if ( $creator_id ) {
         $group->creator_id = (int) $creator_id;
-    } else {
+    } elseif ( is_user_logged_in() ) {
         $group->creator_id = bp_loggedin_user_id();
+    }
+
+    if ( ! $group->creator_id ) {
+        return false;
     }
 

trunk/tests/phpunit/testcases/groups/functions.php

@@ -16 +16 @@
 
         $this->factory->group->create();
-    }
-
-    public function test_creating_new_group_as_anonymous_user() {
-        $g = $this->factory->group->create();
-        $this->assertFalse( $g );
     }