Changeset 9120 for trunk/tests/phpunit/testcases/groups/template.php

Timestamp:

11/03/2014 06:14:06 PM (12 years ago)

Author:

djpaul

Message:

Unit Tests, Groups: update the group factory to set the group's creator_id if one was not passed to the factory.

This is a quicker way of updating hundreds of unit tests where we've previously had a bug that was creating Groups without a valid group creator being set. See #5983 for related changes.

A few tests are counting the number of users in specific circumstances, so those eight tests have been individually updated so that they pass a valid creator_id without us having to refactor the entire test.

The test_group_has_no_members test has also been removed as it is impossible for a group to have no members. This test used to work because of this bug.

File:

• trunk/tests/phpunit/testcases/groups/template.php (modified) (1 diff)

trunk/tests/phpunit/testcases/groups/template.php

@@ -132 +132 @@
      */
     public function test_bp_group_has_members_vanilla() {
-        $g = $this->factory->group->create();
         $u1 = $this->create_user();
         $u2 = $this->create_user();
+        $g  = $this->factory->group->create( array(
+            'creator_id' => $u1,
+        ) );
 
         $this->add_user_to_group( $u1, $g );