Changeset 9120 for trunk/tests/phpunit/testcases/groups/class-bp-group-member-query.php

Timestamp:

11/03/2014 06:14:06 PM (10 years ago)

Author:

djpaul

Message:

Unit Tests, Groups: update the group factory to set the group's creator_id if one was not passed to the factory.

This is a quicker way of updating hundreds of unit tests where we've previously had a bug that was creating Groups without a valid group creator being set. See #5983 for related changes.

A few tests are counting the number of users in specific circumstances, so those eight tests have been individually updated so that they pass a valid creator_id without us having to refactor the entire test.

The test_group_has_no_members test has also been removed as it is impossible for a group to have no members. This test used to work because of this bug.

File:

• trunk/tests/phpunit/testcases/groups/class-bp-group-member-query.php (modified) (6 diffs)

trunk/tests/phpunit/testcases/groups/class-bp-group-member-query.php

@@ -119 +119 @@
 
     public function test_with_group_role_admin() {
-        $g = $this->factory->group->create();
-        $u1 = $this->create_user();
-        $u2 = $this->create_user();
-        $u3 = $this->create_user();
+        $u1 = $this->create_user();
+        $u2 = $this->create_user();
+        $u3 = $this->create_user();
+        $g  = $this->factory->group->create( array(
+            'creator_id' => $u1
+        ) );
         $time = time();
 
@@ -169 +171 @@
 
     public function test_with_group_role_member_admin() {
-        $g = $this->factory->group->create();
-        $u1 = $this->create_user();
-        $u2 = $this->create_user();
-        $u3 = $this->create_user();
+        $u1 = $this->create_user();
+        $u2 = $this->create_user();
+        $u3 = $this->create_user();
+        $g  = $this->factory->group->create( array(
+            'creator_id' => $u1,
+        ) );
         $time = time();
 
@@ -194 +198 @@
 
     public function test_with_group_role_mod_admin() {
-        $g = $this->factory->group->create();
-        $u1 = $this->create_user();
-        $u2 = $this->create_user();
-        $u3 = $this->create_user();
+        $u1 = $this->create_user();
+        $u2 = $this->create_user();
+        $u3 = $this->create_user();
+        $g  = $this->factory->group->create( array(
+            'creator_id' => $u1,
+        ) );
         $time = time();
 
@@ -219 +225 @@
 
     public function test_with_group_role_member_mod_admin() {
-        $g = $this->factory->group->create();
-        $u1 = $this->create_user();
-        $u2 = $this->create_user();
-        $u3 = $this->create_user();
+        $u1 = $this->create_user();
+        $u2 = $this->create_user();
+        $u3 = $this->create_user();
+        $g  = $this->factory->group->create( array(
+            'creator_id' => $u1,
+        ) );
         $time = time();
 
@@ -244 +252 @@
 
     public function test_with_group_role_member_mod_admin_banned() {
-        $g = $this->factory->group->create();
         $u1 = $this->create_user();
         $u2 = $this->create_user();
         $u3 = $this->create_user();
         $u4 = $this->create_user();
+        $g  = $this->factory->group->create( array(
+            'creator_id' => $u1,
+        ) );
         $time = time();
 
@@ -294 +304 @@
         $ids = wp_parse_id_list( array_keys( $query_members->results ) );
         $this->assertEquals( array( $u1, ), $ids );
-    }
-
-    public function test_group_has_no_members() {
-        $g = $this->factory->group->create();
-        $u1 = $this->create_user();
-
-        $query_members = new BP_Group_Member_Query( array(
-            'group_id' => $g,
-            'group_role' => array( 'member', 'mod', 'admin' ),
-        ) );
-
-        $ids = wp_parse_id_list( array_keys( $query_members->results ) );
-        $this->assertEquals( array(), $ids );
     }