Changeset 9119

Timestamp:

11/03/2014 04:57:28 PM (10 years ago)

Author:

djpaul

Message:

Core: partial revert of r9116 (user->id to user->ID changes).

In our legacy user fetching functions, we use something similar to "select ... ID as id" in the SQL. In the reverted changes, we are only using the property to return an array of integers, and the change of the property name was causing PHP to throw "undefined property" messages.

As these lines would have never thrown a WordPress core deprecated warning about using id instead of ID, I'm changing them back to clear the warning message and fix the unit tests.

See #5979

File:

• trunk/src/bp-core/bp-core-classes.php (modified) (3 diffs)

trunk/src/bp-core/bp-core-classes.php

@@ -1064 +1064 @@
 
             foreach ( (array) $paged_users as $user ) {
-                $user_ids[] = $user->ID;
+                $user_ids[] = $user->id;
             }
 
@@ -1135 +1135 @@
         $user_ids = array();
         foreach ( (array) $paged_users as $user )
-            $user_ids[] = (int) $user->ID;
+            $user_ids[] = (int) $user->id;
 
         // Add additional data to the returned results
@@ -1223 +1223 @@
          */
         foreach ( (array) $paged_users as $user )
-            $user_ids[] = $user->ID;
+            $user_ids[] = $user->id;
 
         // Add additional data to the returned results