Changeset 9105

Timestamp:

10/29/2014 07:39:19 PM (11 years ago)

Author:

djpaul

Message:

Core: Page title: remove component name from members component item pages. Additional screens introduced by other plugins have been similarily changes.

This simplifies the <title> for the member profile screens; the longer the title, the less likely it will fit in the narrow space afforded by modern web browsers. I expect most people will only have one tab open for a one member (for example); it's an edge case to have multiple tabs open on different parts of the same user's profile for most/general use.

See #5838, props sooskriszta for the initial patch.

File:

• trunk/src/bp-core/bp-core-filters.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-filters.php

@@ -446 +446 @@
     // Displayed user
     if ( bp_get_displayed_user_fullname() && ! is_404() ) {
-
-        // Get the component's ID to try and get it's name
-        $component_id = $component_name = bp_current_component();
-
-        // Use the actual component name
-        if ( ! empty( $bp->{$component_id}->name ) ) {
-            $component_name = $bp->{$component_id}->name;
-
-        // Fall back on the component ID (probably same as current_component)
-        } elseif ( ! empty( $bp->{$component_id}->id ) ) {
-            $component_name = $bp->{$component_id}->id;
-        }
-
-        // translators: construct the page title. 1 = user name, 2 = component name, 3 = seperator
-        $title = strip_tags( sprintf( __( '%1$s %3$s %2$s', 'buddypress' ), bp_get_displayed_user_fullname(), ucwords( $component_name ), $sep ) );
+        $title = bp_get_displayed_user_fullname();
 
     // A single group
-    } elseif ( bp_is_active( 'groups' ) && ! empty( $bp->groups->current_group ) && ! empty( $bp->bp_options_nav[$bp->groups->current_group->slug] ) ) {
+    } elseif ( bp_is_active( 'groups' ) && ! empty( $bp->groups->current_group ) && ! empty( $bp->bp_options_nav[ $bp->groups->current_group->slug ] ) ) {
         $subnav = isset( $bp->bp_options_nav[ $bp->groups->current_group->slug ][ bp_current_action() ]['name'] ) ? $bp->bp_options_nav[ $bp->groups->current_group->slug ][ bp_current_action() ]['name'] : '';
         // translators: "group name | group nav section name"
@@ -470 +456 @@
     // A single item from a component other than groups
     } elseif ( bp_is_single_item() ) {
-        // translators: "component item name | component nav section name | root component name"
-        $title = sprintf( __( '%1$s | %2$s | %3$s', 'buddypress' ), $bp->bp_options_title, $bp->bp_options_nav[ bp_current_item() ][ bp_current_action() ]['name'], bp_get_name_from_root_slug( bp_get_root_slug() ) );
+        // translators: "component item name | component nav section name"
+        $title = sprintf( __( '%1$s | %2$s', 'buddypress' ), $bp->bp_options_title, $bp->bp_options_nav[ bp_current_item() ][ bp_current_action() ]['name'] );
 
     // An index or directory
     } elseif ( bp_is_directory() ) {
-
         $current_component = bp_current_component();