Changeset 9084 for trunk/src/bp-xprofile/bp-xprofile-classes.php

Timestamp:

10/16/2014 06:20:17 PM (10 years ago)

Author:

johnjamesjacoby

Message:

Update XProfile admin area title CSS and JS to bring it up-to-speed with WordPress 4.0 expectations.

• Remove placeholder attributes on titles and rely on accompanying labels
• Show/hide title labels the way WordPress posts currently do
• Add 20px bottom margin to title wrappers to separate it from descriptions
• Tweak admin area form markup slightly to accommodate these improvements

File:

• trunk/src/bp-xprofile/bp-xprofile-classes.php (modified) (3 diffs)

trunk/src/bp-xprofile/bp-xprofile-classes.php

@@ -494 +494 @@
             <?php endif; ?>
 
-            <form action="<?php echo esc_url( $action ); ?>" method="post">
+            <form id="bp-xprofile-add-field-group" action="<?php echo esc_url( $action ); ?>" method="post">
                 <div id="poststuff">
                     <div id="post-body" class="metabox-holder columns-2">
@@ -500 +500 @@
                             <div id="titlediv">
                                 <div id="titlewrap">
-                                    <label class="screen-reader-text" id="title-prompt-text" for="title"><?php esc_html_e( 'Field Group Title', 'buddypress') ?></label>
-                                    <input type="text" name="group_name" autocomplete="off" id="title" value="<?php echo esc_attr( $this->name ); ?>" placeholder="<?php echo esc_attr_x( 'Group Name', 'XProfile admin edit group', 'buddypress' ); ?>" />
+                                    <label id="title-prompt-text" for="title"><?php esc_html_e( 'Field Group Name', 'buddypress') ?></label>
+                                    <input type="text" name="group_name" id="title" value="<?php echo esc_attr( $this->name ); ?>" autocomplete="off" />
                                 </div>
                             </div>
@@ -921 +921 @@
                         <div id="post-body-content">
                             <div id="titlediv">
-                                <input type="text" name="title" id="title" value="<?php echo esc_attr( $this->name ); ?>" placeholder="<?php echo esc_attr_x( 'Field Name', 'XProfile admin edit field', 'buddypress' ); ?>" />
+                                <div class="titlewrap">
+                                    <label id="title-prompt-text" for="title"><?php echo esc_attr_x( 'Field Name', 'XProfile admin edit field', 'buddypress' ); ?></label>
+                                    <input type="text" name="title" id="title" value="<?php echo esc_attr( $this->name ); ?>" autocomplete="off" />
+                                </div>
                             </div>
                             <div class="postbox">