Changeset 9073 for trunk/src/bp-core/bp-core-filters.php

Timestamp:

10/08/2014 02:14:29 PM (12 years ago)

Author:

boonebgorges

Message:

Better detection for false positives in meta SQL filters.

Our wrappers for WP's _metadata() functions require some filtering of the SQL
string (to change a column name and, in the case of xprofile, to add an
'object_type' clause). Our str_replace() logic is too generous, creating the
possibility of matching quoted text, as when the meta value contains the string
'WHERE'.

This changeset modifies the filters so that quoted content is swapped out with
placeholders before we run our search-and-replace.

See #5919.
Props tometzky for feedback.

File:

• trunk/src/bp-core/bp-core-filters.php (modified) (1 diff)

trunk/src/bp-core/bp-core-filters.php

@@ -604 +604 @@
  */
 function bp_filter_metaid_column_name( $q ) {
-        return str_replace( 'meta_id', 'id', $q );
+        /*
+         * Replace quoted content with __QUOTE__ to avoid false positives.
+         * This regular expression will match nested quotes.
+         */
+        $quoted_regex = "/'[^'\\\\]*(?:\\\\.[^'\\\\]*)*'/s";
+        preg_match_all( $quoted_regex, $q, $quoted_matches );
+        $q = preg_replace( $quoted_regex, '__QUOTE__', $q );
+
+        $q = str_replace( 'meta_id', 'id', $q );
+
+        // Put quoted content back into the string.
+        if ( ! empty( $quoted_matches[0] ) ) {
+                for ( $i = 0; $i < count( $quoted_matches[0] ); $i++ ) {
+                        $quote_pos = strpos( $q, '__QUOTE__' );
+                        $q = substr_replace( $q, $quoted_matches[0][ $i ], $quote_pos, 9 );
+                }
+        }
+
+        return $q;
 }