Changeset 9052 for trunk/tests/phpunit/testcases/activity/functions.php

Timestamp:

09/27/2014 09:39:23 PM (10 years ago)

Author:

imath

Message:

Make sure the parent activity exists before adding a comment to it.

There can be a case when the activity displayed in the stream has been deleted by another user. Adding a comment should not be possible for this particular case as the parent activity does not exist anymore. The patch is adding a check on the date_recorded field of the parent activity before adding a comment. If it is not set, then false is returned and a default message is displayed to the user by bp_legacy_theme_new_activity_comment(). As boonebgorges, some improvements on the message can still be added.

See #5907

File:

• trunk/tests/phpunit/testcases/activity/functions.php (modified) (1 diff)

trunk/tests/phpunit/testcases/activity/functions.php

@@ -724 +724 @@
 
     /**
+     * @group bp_activity_new_comment
+     * @group BP5907
+     */
+    public function test_bp_activity_comment_on_deleted_activity() {
+        $a = $this->factory->activity->create();
+
+        bp_activity_delete_by_activity_id( $a );
+
+        $c = bp_activity_new_comment( array(
+            'activity_id' => $a,
+            'parent_id' => $a,
+            'content' => 'foo',
+            'user_id' => 1,
+        ) );
+
+        $this->assertEmpty( $c );
+    }
+
+    /**
      * @group favorites
      * @group bp_activity_add_user_favorite