Changeset 8987

Timestamp:

09/07/2014 09:30:04 PM (10 years ago)

Author:

imath

Message:

Make sure xprofile_sync_bp_profile() happens when a user is edited

Bring back checks on the $update var and WordPress error that were removed in r8810 so that the xProfile sync only happens when a user is edited. Add a unit test.

Props boonebgorges

Fixes #5836

Location:

trunk

Files:

• src/bp-xprofile/bp-xprofile-functions.php (modified) (1 diff)
• tests/phpunit/testcases/xprofile/functions.php (modified) (1 diff)

trunk/src/bp-xprofile/bp-xprofile-functions.php

@@ -768 +768 @@
 
     // Bail if profile syncing is disabled
-    if ( bp_disable_profile_sync() ) {
+    if ( bp_disable_profile_sync() || ! $update || $errors->get_error_codes() ) {
         return;
     }

trunk/tests/phpunit/testcases/xprofile/functions.php

@@ -571 +571 @@
 
     /**
+     * @group xprofile_set_field_data
+     * @ticket BP5836
+     */
+    public function test_xprofile_sync_bp_profile_new_user() {
+        $post_vars = $_POST;
+
+        $_POST = array(
+            'user_login' => 'foobar',
+            'pass1'      => 'password',
+            'pass2'      => 'password',
+            'role'       => 'subscriber',
+            'email'      => 'foo@bar.com',
+            'first_name' => 'Foo',
+            'last_name'  => 'Bar',
+        );
+
+        $id = add_user();
+
+        $display_name = 'Bar Foo';
+
+        $_POST = array(
+            'display_name' => $display_name,
+            'email'        => 'foo@bar.com',
+        );
+
+        $id = edit_user( $id );
+
+        // clean up post vars
+        $_POST = $post_vars;
+
+        $this->assertEquals( $display_name, xprofile_get_field_data( bp_xprofile_fullname_field_id(), $id ) );
+    }
+
+    /**
      * @group xprofile_insert_field
      */