Changeset 8945 for trunk/src/bp-blogs/bp-blogs-filters.php

Timestamp:

08/18/2014 05:32:37 PM (10 years ago)

Author:

r-a-y

Message:

Do not use get_comments() with fields=ids parameter.

fields=ids is only supported in WordPress 4.0:
​https://core.trac.wordpress.org/ticket/28434

This was causing unit test failures in older versions of WordPress.

To workaround this, this commit introduces bp_blogs_comments_clauses_select_by_id(),
which is used as a filter so we can select comments by the comment_ID
column only and is an alternative to the fields=ids approach.

Fixes #5609.

File:

• trunk/src/bp-blogs/bp-blogs-filters.php (modified) (1 diff)

trunk/src/bp-blogs/bp-blogs-filters.php

@@ -37 +37 @@
 }
 add_filter( 'wp_signup_location', 'bp_blogs_creation_location' );
+
+/**
+ * Only select comments by ID instead of all fields when using get_comments().
+ *
+ * @since BuddyPress (2.1.0)
+ *
+ * @see bp_blogs_update_post()
+ *
+ * @param array Current SQL clauses in array format
+ * @return array
+ */
+function bp_blogs_comments_clauses_select_by_id( $retval ) {
+    $retval['fields'] = 'comment_ID';
+    
+    return $retval;
+}