Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
08/18/2014 05:32:37 PM (7 years ago)
Author:
r-a-y
Message:

Do not use get_comments() with fields=ids parameter.

fields=ids is only supported in WordPress 4.0:
https://core.trac.wordpress.org/ticket/28434

This was causing unit test failures in older versions of WordPress.

To workaround this, this commit introduces bp_blogs_comments_clauses_select_by_id(),
which is used as a filter so we can select comments by the comment_ID
column only and is an alternative to the fields=ids approach.

Fixes #5609.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-blogs/bp-blogs-filters.php

    r7555 r8945  
    3737}
    3838add_filter( 'wp_signup_location', 'bp_blogs_creation_location' );
     39
     40/**
     41 * Only select comments by ID instead of all fields when using get_comments().
     42 *
     43 * @since BuddyPress (2.1.0)
     44 *
     45 * @see bp_blogs_update_post()
     46 *
     47 * @param array Current SQL clauses in array format
     48 * @return array
     49 */
     50function bp_blogs_comments_clauses_select_by_id( $retval ) {
     51    $retval['fields'] = 'comment_ID';
     52   
     53    return $retval;
     54}
Note: See TracChangeset for help on using the changeset viewer.