Changeset 8945

Timestamp:

08/18/2014 05:32:37 PM (10 years ago)

Author:

r-a-y

Message:

Do not use get_comments() with fields=ids parameter.

fields=ids is only supported in WordPress 4.0:
​https://core.trac.wordpress.org/ticket/28434

This was causing unit test failures in older versions of WordPress.

To workaround this, this commit introduces bp_blogs_comments_clauses_select_by_id(),
which is used as a filter so we can select comments by the comment_ID
column only and is an alternative to the fields=ids approach.

Fixes #5609.

Location:

trunk/src/bp-blogs

Files:

• bp-blogs-filters.php (modified) (1 diff)
• bp-blogs-functions.php (modified) (3 diffs)

trunk/src/bp-blogs/bp-blogs-filters.php

@@ -37 +37 @@
 }
 add_filter( 'wp_signup_location', 'bp_blogs_creation_location' );
+
+/**
+ * Only select comments by ID instead of all fields when using get_comments().
+ *
+ * @since BuddyPress (2.1.0)
+ *
+ * @see bp_blogs_update_post()
+ *
+ * @param array Current SQL clauses in array format
+ * @return array
+ */
+function bp_blogs_comments_clauses_select_by_id( $retval ) {
+    $retval['fields'] = 'comment_ID';
+    
+    return $retval;
+}

trunk/src/bp-blogs/bp-blogs-functions.php

@@ -594 +594 @@
 
         // now update activity meta for post comments... sigh
-        $comment_ids = get_comments( array( 'post_id' => $post->ID, 'fields' => 'ids' ) );
-
-        if ( ! empty( $comment_ids ) ) {
+        add_filter( 'comments_clauses', 'bp_blogs_comments_clauses_select_by_id' );
+        $comments = get_comments( array( 'post_id' => $post->ID ) );
+        remove_filter( 'comments_clauses', 'bp_blogs_comments_clauses_select_by_id' );
+
+        if ( ! empty( $comments ) ) {
             $activity_ids = array();
+            $comment_ids  = wp_list_pluck( $comments, 'comment_ID' );
 
             // setup activity args
@@ -608 +611 @@
             // query for old-style "new_blog_comment" activity items
             $args['filter'] = array(
-                'object'     => buddypress()->blogs->id,
-                'action'     => 'new_blog_comment',
+                'object'       => buddypress()->blogs->id,
+                'action'       => 'new_blog_comment',
                 'secondary_id' => implode( ',', $comment_ids ),
             );
@@ -640 +643 @@
             }
 
-            unset( $activities, $activity_ids, $comment_ids );
+            unset( $activities, $activity_ids, $comment_ids, $comments );
         }
     }