Changeset 8934

Timestamp:

08/17/2014 06:11:40 PM (10 years ago)

Author:

boonebgorges

Message:

BP_Group_Extension should automatically handle redirects after the 'edit' screen save routine

After handling POSTed settings save on the 'edit' view of a BP_Group_Extension
plugin, plugins were previously required to handle their own redirects
(primarily to avoid "are you sure you want to resubmit the data?" browser
prompts when reloading the page). This created a disparity between the 'edit'
screen and the 'create' and 'admin' screens, the latter two of which handled
their own redirect logic.

This changeset performs the necessary redirect after calling the edit screen
save callback. There is some logic in place to ensure that no double redirects
take place.

Fixes #5557

File:

• trunk/src/bp-groups/bp-groups-classes.php (modified) (3 diffs)

trunk/src/bp-groups/bp-groups-classes.php

@@ -3002 +3002 @@
 
     /**
+     * Redirect location as defined by post-edit save callback.
+     *
+     * @since BuddyPress (2.1.0)
+     * @var string
+     */
+    protected $post_save_redirect;
+
+    /**
      * Miscellaneous data as set by the __set() magic method.
      *
@@ -3690 +3698 @@
 
         $this->check_nonce( 'edit' );
+
+        // Detect whether the screen_save_callback is performing a
+        // redirect, so that we don't do one of our own
+        add_filter( 'wp_redirect', array( $this, 'detect_post_save_redirect' ) );
+
+        // Call the extension's save routine
         call_user_func( $this->screens['edit']['screen_save_callback'], $this->group_id );
+
+        // Clean up detection filters
+        remove_filter( 'wp_redirect', array( $this, 'detect_post_save_redirect' ) );
+
+        // Perform a redirect only if one has not already taken place
+        if ( empty( $this->post_save_redirect ) ) {
+            $redirect_to = apply_filters( 'bp_group_extension_edit_screen_save_redirect', bp_get_requested_url( ) );
+
+            bp_core_redirect( $redirect_to );
+            die();
+        }
     }
 
@@ -3752 +3777 @@
         preg_match( $pattern, $screen, $matches );
         return ! empty( $matches[0] );
+    }
+
+    /**
+     * Detect redirects hardcoded into edit_screen_save() callbacks.
+     *
+     * @since BuddyPress (2.1.0)
+     *
+     * @param string $location
+     * @return string
+     */
+    public function detect_post_save_redirect( $redirect = '' ) {
+        if ( ! empty( $redirect ) ) {
+            $this->post_save_redirect = $redirect;
+        }
+
+        return $redirect;
     }