Changeset 8928 for trunk/tests/phpunit/testcases/core/class-bp-user-query.php

Timestamp:

08/16/2014 12:03:53 PM (11 years ago)

Author:

imath

Message:

Make sure BP_User_Query returns correct results when search term contains the Ampersand character

1. Search terms containing this character was problematic as the "&" is a query var delimiter used in bp_legacy_theme_ajax_querystring() to build the ajax querystring

2. When a xProfile field is saved, the value is sanitized using the xprofile_filter_kses() filter which is converting "&" to "&" before inserting the value in database.

Urlencoding the search terms in bp_legacy_theme_ajax_querystring() and applying wp_kses_normalize_entities() to search terms in BP_User_Query & in bp_xprofile_bp_user_query_search() make sure the correct results are returned to the user.

Fixes #5694

File:

• trunk/tests/phpunit/testcases/core/class-bp-user-query.php (modified) (1 diff)

trunk/tests/phpunit/testcases/core/class-bp-user-query.php

@@ -202 +202 @@
     }
 
+    public function test_bp_user_query_search_with_ampersand_sign() {
+
+        // LIKE special character: &
+        $user_id = $this->create_user();
+        xprofile_set_field_data( 1, $user_id, "a&mpersand" );
+        $q = new BP_User_Query( array( 'search_terms' => "a&m", ) );
+
+        $found_user_id = null;
+        if ( ! empty( $q->results ) ) {
+            $found_user = array_pop( $q->results );
+            $found_user_id = $found_user->ID;
+        }
+
+        $this->assertEquals( $user_id, $found_user_id );
+
+    }
+
     /**
      * @group search_terms