Changeset 8828

Timestamp:

08/13/2014 07:01:26 PM (11 years ago)

Author:

r-a-y

Message:

bp-legacy: Fix 'Maximum Execution Time' fatal error when attempting to reply to an activity item.

Changes in r8708 caused an infinite loop to occur while manually
determining the activity comment's depth. This is due to the type casting
in r8708.

To fix this in bp-legacy, we also type cast the various item IDs to prevent
the infinite loop from occurring.

Fixes #5811.

File:

• trunk/src/bp-templates/bp-legacy/buddypress-functions.php (modified) (1 diff)

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -793 +793 @@
         // determine depth
         $depth = 1;
-        $parent_id = $activities_template->activities[0]->secondary_item_id;
-        while ( $parent_id !== $activities_template->activities[0]->item_id ) {
+        $parent_id = (int) $activities_template->activities[0]->secondary_item_id;
+        while ( $parent_id !== (int) $activities_template->activities[0]->item_id ) {
             $depth++;
             $p_obj = new BP_Activity_Activity( $parent_id );
-            $parent_id = $p_obj->secondary_item_id;
+            $parent_id = (int) $p_obj->secondary_item_id;
         }
         $activities_template->activity->current_comment->depth = $depth;