Changeset 8655

Timestamp:

07/20/2014 09:41:10 PM (10 years ago)

Author:

djpaul

Message:

i18n improvements in Message notifications

Add singular form of “you have x new private messages”, and use
bp_core_number_format to format the number correctly for the locale.

See #5767, props SGr33n

File:

• trunk/src/bp-messages/bp-messages-notifications.php (modified) (3 diffs)

trunk/src/bp-messages/bp-messages-notifications.php

@@ -123 +123 @@
  */
 function messages_format_notifications( $action, $item_id, $secondary_item_id, $total_items, $format = 'string' ) {
+    $total_items = (int) $total_items;
 
     if ( 'new_message' === $action ) {
@@ -128 +129 @@
         $title = __( 'Inbox', 'buddypress' );
 
-        if ( (int) $total_items > 1 ) {
-            $text   = sprintf( __( 'You have %d new messages', 'buddypress' ), (int) $total_items );
+        if ( $total_items > 1 ) {
+            $text   = sprintf( __( 'You have %d new messages', 'buddypress' ), $total_items );
             $filter = 'bp_messages_multiple_new_message_notification';
         } else {
@@ -142 +143 @@
                 $text = sprintf( __( '%s sent you a new private message', 'buddypress' ), bp_core_get_user_displayname( $secondary_item_id ) );
             } else {
-                $text = sprintf( __( 'You have %d new private messages', 'buddypress' ), (int) $total_items );
+                $text = sprintf( _n( 'You have %s new private message', 'You have %s new private messages', $total_items, 'buddypress' ), bp_core_number_format( $total_items ) );
             }
             $filter = 'bp_messages_single_new_message_notification';